improve http transport error and message handling#2463
Open
kebeney wants to merge 1 commit intowinstonjs:masterfrom
Open
improve http transport error and message handling#2463kebeney wants to merge 1 commit intowinstonjs:masterfrom
kebeney wants to merge 1 commit intowinstonjs:masterfrom
Conversation
…arn even when error occurs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update http.js to emit the info message along with the error when the warn event is fired. The warn event is fired when there is an error sending the log to the http endpoint. This will help for someone who wants to write the logs to local storage and retry later.