Clone incoming objects to prevent incoming data mutation (Issue #1775)#2343
Open
mattrusso9037 wants to merge 13 commits intowinstonjs:masterfrom
Open
Clone incoming objects to prevent incoming data mutation (Issue #1775)#2343mattrusso9037 wants to merge 13 commits intowinstonjs:masterfrom
mattrusso9037 wants to merge 13 commits intowinstonjs:masterfrom
Conversation
…s in create-logger
…s cannot be copied
…e custom properties are not lost. Updated unit test to check properties instead of instance since we are not modifying the original data
…eDeep" This reverts commit a903bd0.
…ed in are not mutated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the issue #1775 by creating a copy of the incoming data before mutating it.