Skip to content

Add keyboard support for Khiamniungan Naga (kix) - #858

Merged
srish merged 3 commits into
wikimedia:masterfrom
ToluAyodele:T428848
Aug 13, 2026
Merged

Add keyboard support for Khiamniungan Naga (kix)#858
srish merged 3 commits into
wikimedia:masterfrom
ToluAyodele:T428848

Conversation

@ToluAyodele

Copy link
Copy Markdown
Contributor

@ToluAyodele
ToluAyodele requested a review from srish July 22, 2026 17:44

@srish srish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ToluAyodele for the PR! I have a few questions before I can approve this:

@srish srish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule wise changes are looking good now. Requesting a documentation and few more indentation and formatting related changes. See comments inline.

Comment thread rules/kix/kix-tilde.js Outdated
name: 'Khiamniungan tilde',
description: 'Khiamniungan Naga input keyboard',
date: '2026-07-22',
URL: 'https://github.com/wikimedia/jquery.ime',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation link needs to be added.

Comment thread rules/kix/kix-tilde.js Outdated
version: '1.0',
maxKeyLength: 3,
patterns: [
[ '~u', 'ü' ], // U+00FC

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the comments are column aligned. Rest of the repo doesn't follow this convention.

Comment thread test/jquery.ime.test.fixtures.js Outdated
description: 'Khiamniungan Naga tilde test',
inputmethod: 'kix-tilde',
tests: [
// Group 1: a, e, i × 4 tones (unchanged – passes)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixture style here diverges from the rest of the file. We can add input, output and description in single lines and then remove all the comments from this file. You could try adding two more test cases - capital tone-marked vowels (A~\E~-I~^O~/U~\ → ÀĒÎÓÙ) and a real word (h~u~-he~^i → hǖhêi).

Comment thread rules/kix/kix-tilde.js Outdated
author: 'Toluwanimi Ayodele',
license: 'GPLv3',
version: '1.0',
maxKeyLength: 3,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 2 given this is the length of largest regex sequence in the patterns.

@srish
srish merged commit dd7c708 into wikimedia:master Aug 13, 2026
3 checks passed
@ToluAyodele
ToluAyodele deleted the T428848 branch August 18, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants