Skip to content

SCA-5930 Fix intermittent UA UPDATE "Read timed out" by disabling stale connection reuse #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenLuigi merged 1 commit into from
Jun 29, 2026
Merged

SCA-5930 Fix intermittent UA UPDATE "Read timed out" by disabling stale connection reuse #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions wss-agent-client/src/main/java/org/whitesource/agent/client/WssServiceClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import org.apache.http.conn.scheme.Scheme;
import org.apache.http.conn.scheme.SchemeRegistry;
import org.apache.http.conn.ssl.SSLSocketFactory;
import org.apache.http.impl.NoConnectionReuseStrategy;
import org.apache.http.impl.client.*;
import org.apache.http.impl.conn.DefaultProxyRoutePlanner;
import org.apache.http.impl.conn.tsccm.ThreadSafeClientConnManager;
Expand Down Expand Up @@ -187,6 +188,15 @@ public WssServiceClientImpl(String serviceUrl, boolean setProxy, int connectionT

setConnectionTimeout(this.connectionTimeout);

// Never reuse a persistent (keep-alive) connection. A pooled connection that an upstream
// load balancer / proxy / firewall has silently dropped (half-open) would otherwise be
// reused for the next request; the request is then written into a dead socket, no response
// ever arrives, and the read blocks for the full connection timeout (default 60 minutes)
// before the agent retries on a fresh connection. Forcing a fresh connection per request
// removes that "first attempt times out, retry succeeds" failure. The cost is one extra
// connection setup per request, which is negligible for the agent's request volume.
((DefaultHttpClient) httpClient).setReuseStrategy(new NoConnectionReuseStrategy());

if (this.proxyEnabled) {
findDefaultProxy();
}
Expand Down Expand Up @@ -275,7 +285,9 @@ public void setProxy(String host, int port, String username, String password) {
HttpHost proxy = new HttpHost(proxyHost, proxyPort);
// httpClient.getParams().setParameter(ConnRoutePNames.DEFAULT_PROXY, proxy);
DefaultProxyRoutePlanner routePlanner = new DefaultProxyRoutePlanner(proxy);
httpClient = HttpClients.custom().setRoutePlanner(routePlanner).build();
// see constructor: disable connection reuse to avoid reusing a stale/half-open connection
httpClient = HttpClients.custom().setRoutePlanner(routePlanner)
.setConnectionReuseStrategy(new NoConnectionReuseStrategy()).build();
logger.info("Using proxy: " + proxy.toHostString());

if (proxyUsername != null && proxyUsername.trim().length() > 0) {
Expand All @@ -293,7 +305,8 @@ public void setProxy(String host, int port, String username, String password) {
credsProvider.setCredentials(AuthScope.ANY, credentials);
// TODO check
httpClient = HttpClientBuilder.create().setProxy(proxy)
.setDefaultCredentialsProvider(credsProvider).build();
.setDefaultCredentialsProvider(credsProvider)
.setConnectionReuseStrategy(new NoConnectionReuseStrategy()).build();

// httpClient.getCredentialsProvider().setCredentials(AuthScope.ANY, credentials);
}
Expand Down