Deliver before launch and defer the callback for iOS same-device signing - #49
Open
aaroncox wants to merge 3 commits into
Open
Deliver before launch and defer the callback for iOS same-device signing#49aaroncox wants to merge 3 commits into
aaroncox wants to merge 3 commits into
Conversation
dafuga
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes same-device signing on iOS Safari reliable. Depends on wharfkit/protocol-esr#4.
Three changes to
NativeTransport.sign():receiveReturnedTransaction. Apps that skip the receive helper are unaffected and the record expires with the request.For discussion: the
anchor://linknavigation now fires after an awaited network call, outside the synchronous user-gesture window. Safari permits it and the flow was verified end to end on a physical iPhone, but Safari's gesture policies have changed between releases. If this regresses, an alternative is racing the send against a bounded pre-launch delay.Desktop, Android, the popup flow, and the non-same-device paths are unchanged. 119 tests pass (114 existing, 5 new). Published as 1.8.0-rc1 under the
nexttag.