[Graphite MQ] Draft PR GROUP:spec_1eba87 (PRs 2788, 2789, 2790) - #2793
Closed
graphite-app[bot] wants to merge 3 commits into
Closed
[Graphite MQ] Draft PR GROUP:spec_1eba87 (PRs 2788, 2789, 2790)#2793graphite-app[bot] wants to merge 3 commits into
graphite-app[bot] wants to merge 3 commits into
Conversation
NormalizeOSImageName matched the literal "RHEL", but Kubernetes reports osImage as "Red Hat Enterprise Linux 9.7 (Plow)", so every RHEL node normalized to "unknown-os" and its builder containers were named after it. Rocky had the same gap: "rocky\s*(\d+)" never matched "Rocky Linux 8.10". Widen both patterns and add a table test covering the spellings Kubernetes actually emits. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The copy-cli init container staged whatever `weka` resolved to in the builder image, so the driver extraction ran an old CLI pinned in builder-ubuntu*-v1 rather than the one shipped with the cluster image being built. Pick the CLI source via weka_get_copy_local_driver_files, the same flag the loader already keys on, and route both callers through one helper so the two cannot drift apart. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
copy-cli resolved the CLI through PATH, which in the cluster image points at the release binary rather than the wekactl one, and staging it was inert anyway: the builder invokes a bare `weka`, and the operator wrapper at /usr/local/bin/weka execs /usr/bin/weka, so the staged copy was never reached. Glob the wekactl binary by arch, make it executable (the source is 0644), and shadow /usr/bin/weka with a subPath mount so the container runs it without weka_runtime.py having to name the path. Fall back to the previous PATH resolution for images with no wekactl-*, and fail loudly if neither exists. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
graphite-app
Bot
deleted the
gtmq_spec_1eba87_1788432671329-2ea33494-ba7c-459c-95da-df929b545dbe
branch
September 3, 2026 11:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR was created by the Graphite merge queue.
Trunk will be fast forwarded to the HEAD of this PR when CI passes, and the original PRs will be closed.
The following PRs are included in this draft PR: