Skip to content

feat: support full-drive wekacluster acting as a daemonset and using all drives (OP-345) - #2742

Open
kristina-solovyova wants to merge 1 commit into
08-17-refactor_share_node_eligibility_and_pod_status_helpers_op-345_from
08-10-feat_support_full-drive_wekacluster_acting_as_a_daemonset_and_using_all_drives_op-345_
Open

feat: support full-drive wekacluster acting as a daemonset and using all drives (OP-345)#2742
kristina-solovyova wants to merge 1 commit into
08-17-refactor_share_node_eligibility_and_pod_status_helpers_op-345_from
08-10-feat_support_full-drive_wekacluster_acting_as_a_daemonset_and_using_all_drives_op-345_

Conversation

@kristina-solovyova

Copy link
Copy Markdown
Collaborator

No description provided.

kristina-solovyova commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label main-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kristina-solovyova
kristina-solovyova force-pushed the 08-10-feat_support_full-drive_wekacluster_acting_as_a_daemonset_and_using_all_drives_op-345_ branch from 6b237b1 to a3a7408 Compare August 17, 2026 08:55
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@weka weka deleted a comment from claude Bot Aug 17, 2026
@kristina-solovyova
kristina-solovyova changed the base branch from main to graphite-base/2742 August 17, 2026 10:25
@kristina-solovyova
kristina-solovyova force-pushed the 08-10-feat_support_full-drive_wekacluster_acting_as_a_daemonset_and_using_all_drives_op-345_ branch from a3a7408 to 43d29a4 Compare August 17, 2026 10:25
@kristina-solovyova
kristina-solovyova changed the base branch from graphite-base/2742 to 08-17-refactor_share_node_eligibility_and_pod_status_helpers_op-345_ August 17, 2026 10:25
@kristina-solovyova
kristina-solovyova force-pushed the 08-10-feat_support_full-drive_wekacluster_acting_as_a_daemonset_and_using_all_drives_op-345_ branch from 43d29a4 to 7234df5 Compare August 17, 2026 12:50
@kristina-solovyova
kristina-solovyova force-pushed the 08-17-refactor_share_node_eligibility_and_pod_status_helpers_op-345_ branch from 40a77b5 to 60f12b3 Compare August 17, 2026 14:14
@kristina-solovyova
kristina-solovyova force-pushed the 08-10-feat_support_full-drive_wekacluster_acting_as_a_daemonset_and_using_all_drives_op-345_ branch from 7234df5 to 15b562d Compare August 17, 2026 14:14
@kristina-solovyova
kristina-solovyova force-pushed the 08-17-refactor_share_node_eligibility_and_pod_status_helpers_op-345_ branch from 60f12b3 to 336b1f9 Compare August 17, 2026 14:28
@kristina-solovyova
kristina-solovyova force-pushed the 08-10-feat_support_full-drive_wekacluster_acting_as_a_daemonset_and_using_all_drives_op-345_ branch from 15b562d to 20a7c59 Compare August 17, 2026 14:28
@kristina-solovyova
kristina-solovyova force-pushed the 08-17-refactor_share_node_eligibility_and_pod_status_helpers_op-345_ branch from 336b1f9 to fa21afa Compare August 19, 2026 13:50
@kristina-solovyova
kristina-solovyova force-pushed the 08-10-feat_support_full-drive_wekacluster_acting_as_a_daemonset_and_using_all_drives_op-345_ branch 2 times, most recently from 3065398 to 7c618ed Compare August 19, 2026 15:28
@kristina-solovyova
kristina-solovyova marked this pull request as ready for review August 19, 2026 15:29
@kristina-solovyova
kristina-solovyova requested a review from a team as a code owner August 19, 2026 15:29
@graphite-app
graphite-app Bot requested review from assafgi and tigrawap and removed request for tigrawap August 19, 2026 15:29
@graphite-app

graphite-app Bot commented Aug 19, 2026

Copy link
Copy Markdown

Graphite Automations

"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (08/19/26)

2 reviewers were added to this PR based on Anton Bykov's automation.

@kristina-solovyova
kristina-solovyova force-pushed the 08-10-feat_support_full-drive_wekacluster_acting_as_a_daemonset_and_using_all_drives_op-345_ branch from 603ec88 to f2c2f62 Compare August 28, 2026 05:32
@kristina-solovyova
kristina-solovyova force-pushed the 08-17-refactor_share_node_eligibility_and_pod_status_helpers_op-345_ branch from fa21afa to a52d8cf Compare August 28, 2026 05:32
…all drives (OP-345)

A WekaCluster that sets neither container counts nor a capacity target now acts as a
daemonset: one drive container per eligible node claiming every signed full drive, with
compute containers and cores/hugepages derived from the resulting fleet capacity.

capacityplanner gains PlanAutoFullDrives alongside PlanCapacity, and the helpers both
planners share move out of planner.go. In the wekacluster controller the planner result
gets its own apply layer (steps_planner_apply.go) and throttled event reporting.

Two shared-drives behaviours change with them: pinned cores are now hard-capped by
maxCoresPerContainer, and TLC/QLC pool ordering accounts for pools already used on a node.
capacityplanner_shim.go is deleted; the weka-capacity CLI moves onto the package directly,
renaming maxComputeCoresPerNode -> maxCoresPerContainer.

Thirteen assertions in collect_test.go and templates_test.go computed their expected value
by calling the function under test, so no formula change could fail them; they now pin
literals.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@kristina-solovyova
kristina-solovyova force-pushed the 08-17-refactor_share_node_eligibility_and_pod_status_helpers_op-345_ branch from a52d8cf to fc6be78 Compare September 1, 2026 18:43
@kristina-solovyova
kristina-solovyova force-pushed the 08-10-feat_support_full-drive_wekacluster_acting_as_a_daemonset_and_using_all_drives_op-345_ branch from f2c2f62 to 23073f7 Compare September 1, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant