fix: Use runtime FS case-sensitivity check in cspell and taskfile tests#1613
Closed
Zamiell wants to merge 2 commits intowebpro-nl:mainfrom
Closed
fix: Use runtime FS case-sensitivity check in cspell and taskfile tests#1613Zamiell wants to merge 2 commits intowebpro-nl:mainfrom
Zamiell wants to merge 2 commits intowebpro-nl:mainfrom
Conversation
Replace `process.platform === 'win32'` checks with a helper that tests actual filesystem case-sensitivity at runtime. Windows directories can have per-directory case-sensitivity enabled, making the platform check an unreliable proxy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
commit: |
Zamiell
changed the title
Member
|
Appreciate the PR, but should not be an issue after merging #1462. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cloned the knip repo and ran
pnpm testand it just immediately fails.The reason is because knip assumes that if you are on Windows, you are on a case insensitive file system.
But this is not true - it is best practice to set your "repositories" directory to be case sensitive.
Thus, this PR replaces
process.platform === 'win32'checks with a helper that tests actual filesystem case-sensitivity at runtime.Claude helped me write this.