Replace fast-glob with tinyglobby

[gameroman]

Closes #1446

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/knip@1447

commit: 6ef9df8

[webpro]

Thanks for bringing this up again, and the efforts already put in. I'm going to change the title to make it clear that we should really only merge if we can get this right.

[gameroman]

looks like there are 4 places where the firstGlob function is used

knip/packages/knip/src/plugins/yarn/index.ts

Line 10 in 5b98269

const isEnabled: IsPluginEnabled = async ({ cwd }) => Boolean(await _firstGlob({ cwd, patterns: ['yarn.lock'] }));

knip/packages/knip/src/plugins/taskfile/index.ts

Line 21 in 5b98269

return Boolean(await _firstGlob({ cwd, patterns: defaultConfigPatterns }));

knip/packages/knip/src/plugins/github-actions/index.ts

Line 15 in 5b98269

Boolean(await _firstGlob({ cwd, patterns: ['.github/workflows/*.{yml,yaml}'] }));

knip/packages/knip/src/plugins/pnpm/index.ts

Line 11 in 5b98269

(await _firstGlob({ cwd, patterns: ['pnpm-lock.yaml', 'pnpm-workspace.yaml'] }))

[gameroman]

@webpro I removed 2 of the usages and will see if I can deal with the other 2

[gameroman]

removed another one

[gameroman]

removed the last one

[silverwind]

Could use fsPromises.glob as well, given that it's available in Node 22 and greater which matches the minimum version of this module.

[webpro]

Knip requires at least Node.js v18, tinyglobby v12. And I don't expect Knip to reach the fs.glob threshold too soon, as it might be helpful in legacy projects trying to keep up. That said, using built-ins is usually a good idea once we can (but tbh haven't looked into differences here recently).

[silverwind]

Ah sorry, I was looking at the wrong package.json, carry on :D

[gameroman]

#1462