Skip to content

Fix:Language dropdown hover spacing #8187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 2 commits into from
Apr 13, 2026
+24 −29
Merged

Fix:Language dropdown hover spacing #8187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6a1726
fix(dropdown): improve language menu hover spacing
Sahilshrma31 Apr 12, 2026
513bcad
test: update snapshot and fix hidden class assertion
Sahilshrma31 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/components/Dropdown/Dropdown.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,14 +126,11 @@ export default function Dropdown({ className = "", items = [] }) {
<div
className={`${
active ? "block" : "hidden"
} absolute top-full right-0 text-[13px] bg-[#526b78] rounded-md shadow-[0_4px_12px_rgba(0,0,0,0.4)] z-[9999]`}
} absolute top-full left-1/2 -translate-x-1/2 overflow-hidden text-[13px] bg-[#526b78] rounded-md shadow-[0_4px_12px_rgba(0,0,0,0.4)] z-[9999]`}
>
<ul className="pt-1">
<ul>
{items.map((item, i) => (
<li
key={item.title}
className="py-1 px-2 list-none text-white transition-all duration-[250ms] hover:bg-[#175d96]"
>
<li key={item.title} className="list-none">
<a
onKeyDown={(event) =>
handleArrowKeys(i, items.length - 1, event)
Expand All @@ -142,7 +139,7 @@ export default function Dropdown({ className = "", items = [] }) {
linksRef.current[i] = node;
}}
href={item.url}
className="px-5 block text-white visited:text-white hover:text-white"
className="block min-w-[88px] px-3 py-1 text-center text-white transition-colors duration-[200ms] visited:text-white hover:bg-[#175d96] hover:text-white focus:bg-[#175d96] focus:text-white"
>
<span lang={item.lang} className="align-top text-left">
{item.title}
Expand Down
24 changes: 12 additions & 12 deletions src/components/Dropdown/Dropdown.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const items = [
];

function getListWrapper(container) {
return container.querySelector("ul").closest("div").className;
return container.querySelector("ul").closest("div");
}

describe("Dropdown", () => {
Expand All @@ -30,15 +30,15 @@ describe("Dropdown", () => {

it("hides the dropdown by default", () => {
const { container } = render(<Dropdown items={items} />);
expect(getListWrapper(container)).toContain("hidden");
expect(getListWrapper(container).classList.contains("hidden")).toBe(true);
});

it("shows the dropdown on hover", () => {
const { container } = render(<Dropdown items={items} />);
const nav = container.querySelector("nav");

fireEvent.mouseOver(nav);
expect(getListWrapper(container)).not.toContain("hidden");
expect(getListWrapper(container).classList.contains("hidden")).toBe(false);
});

it("hides the dropdown on mouse leave", () => {
Expand All @@ -47,18 +47,18 @@ describe("Dropdown", () => {

fireEvent.mouseOver(nav);
fireEvent.mouseLeave(nav);
expect(getListWrapper(container)).toContain("hidden");
expect(getListWrapper(container).classList.contains("hidden")).toBe(true);
});

it("toggles dropdown on button click", () => {
const { container } = render(<Dropdown items={items} />);
const button = screen.getByRole("button", { name: /select language/i });

fireEvent.click(button);
expect(getListWrapper(container)).not.toContain("hidden");
expect(getListWrapper(container).classList.contains("hidden")).toBe(false);

fireEvent.click(button);
expect(getListWrapper(container)).toContain("hidden");
expect(getListWrapper(container).classList.contains("hidden")).toBe(true);
});

it("sets aria-expanded correctly", () => {
Expand All @@ -82,29 +82,29 @@ describe("Dropdown", () => {
const button = screen.getByRole("button", { name: /select language/i });

fireEvent.click(button);
expect(getListWrapper(container)).not.toContain("hidden");
expect(getListWrapper(container).classList.contains("hidden")).toBe(false);

act(() => {
document.dispatchEvent(
new KeyboardEvent("keyup", { key: "Escape", bubbles: true }),
);
});

expect(getListWrapper(container)).toContain("hidden");
expect(getListWrapper(container).classList.contains("hidden")).toBe(true);
});

it("closes when clicking outside", () => {
const { container } = render(<Dropdown items={items} />);
const button = screen.getByRole("button", { name: /select language/i });

fireEvent.click(button);
expect(getListWrapper(container)).not.toContain("hidden");
expect(getListWrapper(container).classList.contains("hidden")).toBe(false);

act(() => {
document.dispatchEvent(new MouseEvent("click", { bubbles: true }));
});

expect(getListWrapper(container)).toContain("hidden");
expect(getListWrapper(container).classList.contains("hidden")).toBe(true);
});

it("does not close dropdown when arrow keys are pressed", () => {
Expand All @@ -114,10 +114,10 @@ describe("Dropdown", () => {

const links = screen.getAllByRole("link");
fireEvent.keyDown(links[0], { key: "ArrowDown" });
expect(getListWrapper(container)).not.toContain("hidden");
expect(getListWrapper(container).classList.contains("hidden")).toBe(false);

fireEvent.keyDown(links[links.length - 1], { key: "ArrowDown" });
expect(getListWrapper(container)).not.toContain("hidden");
expect(getListWrapper(container).classList.contains("hidden")).toBe(false);
});

it("matches snapshot", () => {
Expand Down
18 changes: 8 additions & 10 deletions src/components/Dropdown/__snapshots__/Dropdown.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,14 @@ exports[`Dropdown matches snapshot 1`] = `
/>
</button>
<div
class="hidden absolute top-full right-0 text-[13px] bg-[#526b78] rounded-md shadow-[0_4px_12px_rgba(0,0,0,0.4)] z-[9999]"
class="hidden absolute top-full left-1/2 -translate-x-1/2 overflow-hidden text-[13px] bg-[#526b78] rounded-md shadow-[0_4px_12px_rgba(0,0,0,0.4)] z-[9999]"
>
<ul
class="pt-1"
>
<ul>
<li
class="py-1 px-2 list-none text-white transition-all duration-[250ms] hover:bg-[#175d96]"
class="list-none"
>
<a
class="px-5 block text-white visited:text-white hover:text-white"
class="block min-w-[88px] px-3 py-1 text-center text-white transition-colors duration-[200ms] visited:text-white hover:bg-[#175d96] hover:text-white focus:bg-[#175d96] focus:text-white"
href="/en/"
>
<span
Expand All @@ -72,10 +70,10 @@ exports[`Dropdown matches snapshot 1`] = `
</a>
</li>
<li
class="py-1 px-2 list-none text-white transition-all duration-[250ms] hover:bg-[#175d96]"
class="list-none"
>
<a
class="px-5 block text-white visited:text-white hover:text-white"
class="block min-w-[88px] px-3 py-1 text-center text-white transition-colors duration-[200ms] visited:text-white hover:bg-[#175d96] hover:text-white focus:bg-[#175d96] focus:text-white"
href="/fr/"
>
<span
Expand All @@ -87,10 +85,10 @@ exports[`Dropdown matches snapshot 1`] = `
</a>
</li>
<li
class="py-1 px-2 list-none text-white transition-all duration-[250ms] hover:bg-[#175d96]"
class="list-none"
>
<a
class="px-5 block text-white visited:text-white hover:text-white"
class="block min-w-[88px] px-3 py-1 text-center text-white transition-colors duration-[200ms] visited:text-white hover:bg-[#175d96] hover:text-white focus:bg-[#175d96] focus:text-white"
href="/es/"
>
<span
Expand Down
Loading