Skip to content

Allow mixins to describe custom elements #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinfagnani merged 8 commits into from
Feb 12, 2021
Merged

Allow mixins to describe custom elements #31

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1af2a7f
Allow mixins to describe custom elements
justinfagnani Nov 13, 2020
ab1ec94
Update schema.ts
justinfagnani Nov 13, 2020
2d1bb35
Update schema.ts
justinfagnani Nov 13, 2020
d1e77b0
Add docs about mixin superclasses
justinfagnani Nov 13, 2020
f5ca047
format
justinfagnani Nov 13, 2020
5ffe59f
regenerate schema json
justinfagnani Nov 13, 2020
f65cdff
Update mixin docs
justinfagnani Nov 14, 2020
6fee0eb
Add link to mixin article
justinfagnani Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,9 @@ export interface ClassMethod extends FunctionLike {
* argument, so consumers of this interface should assume that the return type
* is the single argument subclassed by this declaration.
*
* A mixin should only have a superclass if it composes another mixin, and the
Copy link
Copy Markdown
Collaborator

@thepassle thepassle Nov 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure I understand.

Given:

export const MixinA = base => class extends MixinB(base){}

Here the MixinB would be "superclass"?

What in the case of:

export const MixinA = base => class extends MixinC(MixinB(base)){}

?

Copy link
Copy Markdown
Collaborator Author

@justinfagnani justinfagnani Feb 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was updated to say "a mixins should not have a superclass". In your examples the other mixins would be included in the mixins field of MixinA.

* superclass should reference that mixin.
*
* @example
*
* This JavaScript mixin declaration:
Expand Down