Skip to content

Refactor form permission checking to streamline capability verification #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdmehedi merged 1 commit into from
Feb 24, 2026
Merged

Refactor form permission checking to streamline capability verification #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions includes/Rest/Forms.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,16 +135,11 @@
return false;
}

// 2. Check user has appropriate weMail role-based capabilities
if ( ! function_exists( 'wemail' ) || ! method_exists( wemail(), 'user' ) ) {
return false;
}

if ( ! wemail()->user->can( 'manage_form' ) ) {
return false;
}

// 3. Require nonce verification for CSRF protection
// 2. Require nonce verification for CSRF protection
$nonce = $request->get_header( 'X-WP-Nonce' );
if ( ! $nonce || ! wp_verify_nonce( $nonce, 'wp_rest' ) ) {
return false;
Expand Down Expand Up @@ -272,7 +267,7 @@
*
* @return WP_REST_Response
*/
public function sync( $request ) {

Check warning on line 270 in includes/Rest/Forms.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection 

The method parameter $request is never used
wemail()->form->sync();

return new WP_REST_Response( array( 'success' => true ) );
Expand Down
Loading