fix(wasix): Handle sendto() on connected TCP sockets#6455
Open
artemyarulin wants to merge 2 commits intomainfrom
Open
fix(wasix): Handle sendto() on connected TCP sockets#6455artemyarulin wants to merge 2 commits intomainfrom
artemyarulin wants to merge 2 commits intomainfrom
Conversation
artemyarulin
force-pushed
the
fix/send-tcp-on-open-socket
branch
from
6f1c8e0 to
b42c70c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
sendto()on a connected TCP socket returnedENOTSUPbecause thesend_to()path inlib/wasix/src/net/socket.rsonly handled ICMP and UDP sockets. This change makes the TCP case behave likesend()and ignore the destination address, which matches POSIX behavior for connected stream sockets.Along the way I've added all the POSIX tests for send_to syscall