Skip to content

fix(wasix): Return error when close_fd encountered an error#6451

Open
artemyarulin wants to merge 2 commits intomainfrom
fix/fs-close-error
Open

fix(wasix): Return error when close_fd encountered an error#6451
artemyarulin wants to merge 2 commits intomainfrom
fix/fs-close-error

Conversation

@artemyarulin
Copy link
Copy Markdown
Contributor

Fixes #6436

@artemyarulin
Copy link
Copy Markdown
Contributor Author

/patchsmith test

@artemyarulin
Copy link
Copy Markdown
Contributor Author

Python upstream result: REGRESSION

Baseline: main @ 9164ff3
Candidate: fix/fs-close-error @ 99a485b

Summary:

  • Regressions: 318
  • Improvements: 0
  • FLAKY: 13 -> 65
  • PASS: 28323 -> 27936
  • FAIL: 2603 -> 2920
  • TIMEOUT: 4876 -> 4852
  • SKIP: 2105 -> 2095

See full details at commit.

Top regressions:

  • test.datetimetester.ExtensionModuleTests_Fast.test_gh_120161 (PASS -> FAIL)
  • test.datetimetester.ExtensionModuleTests_Fast.test_update_type_cache (PASS -> FAIL)
  • test.test_atexit.GeneralTest.test_general (PASS -> FAIL)
  • test.test_audit.AuditTest.test_basic (PASS -> FAIL)
  • test.test_audit.AuditTest.test_block_add_hook (PASS -> FAIL)
  • test.test_audit.AuditTest.test_block_add_hook_baseexception (PASS -> FAIL)
  • test.test_audit.AuditTest.test_cantrace (PASS -> FAIL)
  • test.test_audit.AuditTest.test_excepthook (PASS -> FAIL)
  • test.test_audit.AuditTest.test_gc (PASS -> FAIL)
  • test.test_audit.AuditTest.test_http (PASS -> FAIL)

More info:

@artemyarulin
Copy link
Copy Markdown
Contributor Author

/patchsmith test

@artemyarulin
Copy link
Copy Markdown
Contributor Author

Python upstream result: REGRESSION

Baseline: main @ 9164ff3
Candidate: fix/fs-close-error @ 4329350

Summary:

  • Regressions: 15
  • Improvements: 0
  • FLAKY: 13 -> 65
  • PASS: 28323 -> 28311
  • FAIL: 2603 -> 2612
  • TIMEOUT: 4876 -> 4879
  • SKIP: 2105 -> 2105

See full details at commit.

Top regressions:

  • test.test_interpreters.test_api.CreateTests.test_in_subinterpreter (PASS -> FAIL)
  • test.test_interpreters.test_api.GetCurrentTests.test_subinterpreter (PASS -> FAIL)
  • test.test_interpreters.test_api.TestInterpreterClose.test_from_current (PASS -> FAIL)
  • test.test_interpreters.test_api.TestInterpreterExec.test_in_thread (PASS -> FAIL)
  • test.test_interpreters.test_api.TestInterpreterExec.test_success (PASS -> FAIL)
  • test.test_interpreters.test_api.TestInterpreterIsRunning.test_from_subinterpreter (PASS -> FAIL)
  • test.test_interpreters.test_api.TestInterpreterPrepareMain.test_dict (PASS -> FAIL)
  • test.test_interpreters.test_api.TestInterpreterPrepareMain.test_dict_and_kwargs (PASS -> FAIL)
  • test.test_interpreters.test_api.TestInterpreterPrepareMain.test_kwargs (PASS -> FAIL)
  • test.test_interpreters.test_api.TestInterpreterPrepareMain.test_tuple (PASS -> FAIL)

More info:

@artemyarulin
Copy link
Copy Markdown
Contributor Author

/patchsmith test

@artemyarulin
Copy link
Copy Markdown
Contributor Author

Python upstream result: IMPROVEMENT

Baseline: main @ 9164ff3
Candidate: fix/fs-close-error @ 4329350

Summary:

  • Regressions: 0
  • Improvements: 4
  • FLAKY: 5 -> 56
  • PASS: 28323 -> 28327
  • FAIL: 2606 -> 2591
  • TIMEOUT: 4873 -> 4884
  • SKIP: 2105 -> 2105

See full details at commit.

Top improvements:

  • test.test_fileio.CAutoFileTests.testErrnoOnClose (FAIL -> PASS)
  • test.test_fileio.PyAutoFileTests.testErrnoOnClose (FAIL -> PASS)
  • test.test_json.test_recursion.TestCRecursion.test_endless_recursion (FAIL -> PASS)
  • test.test_pty.SmallPtyTests.test__copy_to_each (FAIL -> PASS)

More info:

@artemyarulin
Copy link
Copy Markdown
Contributor Author

Nice - Python upstream tests now works, ready for review

@artemyarulin
Copy link
Copy Markdown
Contributor Author

/patchsmith test

@artemyarulin
Copy link
Copy Markdown
Contributor Author

Python upstream result: IMPROVEMENT

Baseline: main @ df125df
Candidate: fix/fs-close-error @ 4329350

Summary:

  • Regressions: 0
  • Improvements: 3
  • FLAKY: 4 -> 13
  • PASS: 28324 -> 28327
  • FAIL: 2607 -> 2600
  • TIMEOUT: 4871 -> 4875
  • SKIP: 2105 -> 2105

See full details at commit.

Top improvements:

  • test.test_fileio.CAutoFileTests.testErrnoOnClose (FAIL -> PASS)
  • test.test_fileio.PyAutoFileTests.testErrnoOnClose (FAIL -> PASS)
  • test.test_json.test_recursion.TestCRecursion.test_endless_recursion (FAIL -> PASS)

More info:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

close() succeeds on already-closed file descriptors under Wasmer

1 participant