Skip to content

Point stable-skill instructions at resources/bundled/skills/#9406

Merged
vorporeal merged 1 commit intowarpdotdev:masterfrom
anshul-garg27:fix/skills-readme-paths
Apr 29, 2026
Merged

Point stable-skill instructions at resources/bundled/skills/#9406
vorporeal merged 1 commit intowarpdotdev:masterfrom
anshul-garg27:fix/skills-readme-paths

Conversation

@anshul-garg27
Copy link
Copy Markdown
Contributor

Description

The channel-gated skills README and the runtime error message in `script/copy_conditional_skills` both pointed contributors at `resources/skills/` for stable-ready skills, but that directory doesn't exist in the repo — `script/prepare_bundled_resources` copies the always-bundled skills from `resources/bundled/`, so the right destination is `resources/bundled/skills/`.

The result: if anyone bumped into the existing `stable/` guard (`copy_conditional_skills` line 39), the printed remediation pointed them at a path that doesn't exist.

Three updates:

  • `resources/channel-gated-skills/README.md` — "place them in the always-bundled `resources/skills/`" → `resources/bundled/skills/` (in the prose blockquote and in the gating table).
  • `script/copy_conditional_skills` — header comment + the user-facing error `echo`.

No behavior change in the script itself; only the comment and the error string contents.

Testing

Doc/script-comment only — nothing to run. The actual copy logic is unchanged.

Server API

No server changes.

Agent Mode

Not applicable.

Changelog Entries

None.

The channel-gated skills README and the matching error message in
\`script/copy_conditional_skills\` both told contributors to put
stable-ready skills in \`resources/skills/\`, but that directory does
not exist — the always-bundled skills source is
\`resources/bundled/skills/\`, which is what
\`script/prepare_bundled_resources\` actually copies.

Concretely the error message a contributor would hit if they happened
to add a \`stable/\` gate directory was pointing them at the wrong
fix. Updated both the README copy and the runtime echo so they match
the real path.
@cla-bot cla-bot Bot added the cla-signed label Apr 29, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Apr 29, 2026

@anshul-garg27

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I approved this pull request. No matching stakeholder was found for the changed files, so no human reviewers were requested.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR corrects stale stable-skill guidance in resources/channel-gated-skills/README.md and script/copy_conditional_skills to point contributors at resources/bundled/skills/, matching the existing bundled resource layout and copy path.

Concerns

  • No blocking correctness, security, or maintainability concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@alokedesai alokedesai requested a review from vorporeal April 29, 2026 17:07
@vorporeal
Copy link
Copy Markdown
Contributor

thanks for fixing the incorrect paths!

@vorporeal vorporeal merged commit 1849795 into warpdotdev:master Apr 29, 2026
34 checks passed
@captainsafia captainsafia added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Apr 30, 2026 — with Warp Dev Github Integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants