Update persistence README paths to crates/persistence#9405
Update persistence README paths to crates/persistence#9405anshul-garg27 wants to merge 2 commits intowarpdotdev:masterfrom
Conversation
`schema.rs` and `schema.patch` were moved to `crates/persistence/` as part of opening up the source tree, but the migration README still pointed at the old `app/src/persistence/` paths and referenced the `<warp-internal repo>` directory name. - `app/src/persistence/schema.rs` -> `crates/persistence/src/schema.rs` - `app/src/persistence/schema.patch` -> `crates/persistence/schema.patch` - `cd <warp-internal repo>` -> `cd <repo root>` Doc-only change.
|
I'm starting a first review of this pull request. I requested changes on this pull request and posted feedback. Comment I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I approved this pull request. No matching stakeholder was found for the changed files, so no human reviewers were requested. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates several stale persistence README references from the old app/src/persistence layout to crates/persistence.
Concerns
- The README still has another stale schema.patch path in the creation instructions:
git diff -U6 > app/src/persistence/schema.patch. That should also be updated tocrates/persistence/schema.patch; otherwise contributors following the workflow will still write the patch to the old location. This line is outside the inlined diff, so it is summarized here rather than left as an inline comment.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
Good catch — fixed in the follow-up commit. The instruction at the bottom of the README now writes the patch to |
|
/oz-review |
There was a problem hiding this comment.
Overview
This PR updates app/src/persistence/README.md to point migration contributors at the current crates/persistence schema and patch locations and replaces the old internal-repo checkout wording with a repo-root reference.
Concerns
No blocking concerns found. The changed paths match files present in the repository, and the diff is documentation-only with no security-relevant code or configuration changes.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
1 participant
Description
Spotted while running another doc audit:
app/src/persistence/README.mdstill describes the migration workflow in terms of the pre-open-source layout.schema.rsandschema.patchactually live undercrates/persistence/now, and the doc also still tells contributors tocd <warp-internal repo>.Three small text-only fixes:
app/src/persistence/schema.rs→crates/persistence/src/schema.rsapp/src/persistence/schema.patch→crates/persistence/schema.patchcd <warp-internal repo>→cd <repo root>(this is the public repo now; contributors clone it under whatever name they pick)I deliberately left the
our fork of diesel_cliparagraph alone —script/install_cargo_build_depscallscargo binstall --force -y diesel_cliwhich suggests it currently uses upstream, but I'd rather a maintainer confirm whether the bundled-SQLite behavior the README claims is still accurate before rewording that section.Testing
Markdown only — nothing to run.
Server API
No server changes.
Agent Mode
Not applicable.
Changelog Entries
None.