Skip to content

Include .yml and .markdown in Drive import file picker #9400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnavetta merged 2 commits into from
Apr 30, 2026
+17 −2
Merged

Include .yml and .markdown in Drive import file picker #9400

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b03738
Include .yml and .markdown in Drive import file picker
anshul-garg27 Apr 29, 2026
0a5f74c
Move file_picker tests to file_picker_tests.rs per repo convention
anshul-garg27 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions crates/warpui_core/src/platform/file_picker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ impl FileType {
pub fn extensions(&self) -> &[&str] {
match self {
FileType::Image => &["png", "jpg", "jpeg"],
FileType::Yaml => &["yaml"],
FileType::Markdown => &["md"],
FileType::Yaml => &["yaml", "yml"],
FileType::Markdown => &["md", "markdown"],
}
}

Expand Down Expand Up @@ -146,3 +146,18 @@ impl SaveFilePickerConfiguration {
self
}
}

#[cfg(test)]
mod tests {
Copy link
Copy Markdown
Contributor

@bnavetta bnavetta Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per repo conventions, could you put this in a file_picker_tests.rs file alongside this one? You can then use a #[path] attribute to add that file as the test module.

use super::*;

#[test]
fn yaml_file_type_accepts_both_yaml_and_yml() {
assert_eq!(FileType::Yaml.extensions(), &["yaml", "yml"]);
}

#[test]
fn markdown_file_type_accepts_md_and_markdown() {
assert_eq!(FileType::Markdown.extensions(), &["md", "markdown"]);
}
}