Normalize long tool call IDs in agent requests#9396
Normalize long tool call IDs in agent requests#9396qaijuang wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @xosnrdev on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
qaijuang
force-pushed
the
tool-call-id-normalization
branch
from
c1dd1d3 to
170f59f
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @qaijuang on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
@cla-bot check |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @qaijuang on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
The cla-bot has been summoned, and re-checked this pull request! |
qaijuang
force-pushed
the
tool-call-id-normalization
branch
from
170f59f to
ebfadec
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @qaijuang on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I approved this pull request. No matching stakeholder was found for the changed files, so no human reviewers were requested. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR extracts request construction, then normalizes over-limit external tool call IDs in the fully assembled outbound multi-agent request. The normalization is stable, bounded to the downstream limit, and covers task-history tool calls/results plus current user-input tool result and running-command references.
Concerns
- No blocking correctness or security concerns found in the inlined diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
1 participant
Description
What: Normalize over-limit tool call IDs on outbound multi-agent requests.
Why: GLM-5 and Kimi can emit tool call IDs longer than the OpenAI Responses API allows, which causes 400s and unrecoverable agent sessions.
How: Build the request first, then hash over-limit tool call IDs down to a stable
tc_...form across task history tool calls, tool call results, action results, and running-command references. Add focused request-builder regression tests for over-limit, at-limit, and stability behavior.Fixes #8997