Recognize .bmp, .tiff, .tif, and .ico as supported image files

[anshul-garg27]

Description

is_supported_image_file in app/src/util/openable_file_type.rs and is_binary_file in crates/warp_util/src/file_type.rs carry overlapping image-extension lists, but they're not in sync:

Extension	is_binary_file	is_supported_image_file
jpg / jpeg / png / gif / webp	✅	✅
svg	❌ (text-based)	✅
bmp	✅	❌
tiff / tif	✅	❌
ico	✅	❌

The four bottom rows are the bug. Their flow today:

1. is_file_openable_in_warp(file.bmp) → returns None because is_binary_file matches.
2. Callers (e.g. ai/blocklist/block.rs:274, notebooks/link.rs:355, ai/ai_document_view.rs:919) then check is_supported_image_file to decide whether to route to FileTarget::SystemGeneric (i.e. open in Preview / system default).
3. That returns false, so the file falls through with no working target — clicking a .bmp / .tiff / .ico link from a notebook or AI block has no effect.

This change adds the four missing extensions to is_supported_image_file so they route to the system viewer the way .png and friends already do. svg stays in is_supported_image_file only — it's text/XML and correctly excluded from is_binary_file.

Testing

• Added test_is_supported_image_file_covers_common_formats in the existing inline #[cfg(test)] mod tests block. It covers all 10 supported extensions, asserts case-insensitivity (PNG, TIFF), and confirms non-image extensions still return false. Fails on master for the four new extensions; passes after the change.
• cargo fmt -p warp -- --check passes locally.
• Couldn't run cargo nextest locally because the Metal toolchain isn't installed (same caveat as Expand ~ in warp://action/new_tab?path= URLs #9277, Recognize .command files as shell scripts #9345, Also recognize .h++ as a C++ header extension #9346) — relying on CI for the full clippy / nextest pass.

Changelog Entries for Stable

CHANGELOG-BUG-FIX: .bmp, .tiff/.tif, and .ico files now open in the system default viewer when clicked from notebooks and AI blocks, matching the behavior already in place for .png, .jpg, etc.

[oz-for-oss]

@anshul-garg27

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I approved this pull request. No matching stakeholder was found for the changed files, so no human reviewers were requested.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR adds bmp, tiff, tif, and ico to the supported image extension check so binary image links can route to the system viewer, and adds regression coverage for the full supported image list plus case-insensitive extensions.

Concerns

• No blocking correctness, security, or maintainability concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz