fix: remove PR instructions from update skills#392
fix: remove PR instructions from update skills#392oz-for-oss[bot] wants to merge 2 commits intomainfrom
Conversation
Co-Authored-By: Safia Abdalla <captainsafia@users.noreply.github.com>
Co-Authored-By: Oz <oz-agent@warp.dev> Co-Authored-By: Safia Abdalla <captainsafia@users.noreply.github.com>
|
I'm starting a first review of this pull request. You can follow along in the session on Warp. I completed the review and posted feedback on this pull request. Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR removes hardcoded PR/reviewer instructions from the update skills and changes the self-improvement update branches to date-stamped names, with matching entrypoint tests and documentation updates.
Concerns
- Date-only branch names do not fully disambiguate same-day reruns across the update entrypoints. A second run on the same UTC date can collide with an existing remote branch and fail before existing-PR handling.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Powered by Oz
|
|
||
|
|
||
| UPDATE_BRANCH = "oz-agent/update-dedupe" | ||
| UPDATE_BRANCH = f"oz-agent/update-dedupe-{datetime.now(UTC).date().isoformat()}" |
There was a problem hiding this comment.
git push origin <branch> can reject before _pr_exists_for_branch runs. Include a run/attempt component or fetch/update the existing branch before pushing, and apply the same fix to the other update scripts.
2 participants
Closes #391
Summary
update-dedupe,update-pr-review, andupdate-triagefinal checks so agents commit local branch changes only and leave pull-request publication/reviewer assignment to the deterministic workflow.Validation
env PYTHONPATH=.github/scripts /tmp/oz-for-oss-venv/bin/python -m unittest discover -s .github/scripts/tests(485 tests passed)Notes