Skip to content

Feat/ai standards#687

Merged
lucvysk merged 4 commits into
mainfrom
feat/ai-standards
May 14, 2026
Merged

Feat/ai standards#687
lucvysk merged 4 commits into
mainfrom
feat/ai-standards

Conversation

@lucvysk
Copy link
Copy Markdown
Contributor

@lucvysk lucvysk commented May 12, 2026

What is the purpose of this pull request?

setup ai standards

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@lucvysk lucvysk requested a review from a team as a code owner May 12, 2026 19:28
@vtex-io-ci-cd
Copy link
Copy Markdown
Contributor

vtex-io-ci-cd Bot commented May 12, 2026

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link
Copy Markdown

@fdaciuk fdaciuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ótimo trabalho — AGENTS.md detalhado, constitution sólida, rules específicas. PR atinge L1 e L2. Alguns ajustes antes de mergear:

🔴 CLAUDE.md deve ser symlink, não cópia

Atualmente é um arquivo regular (mode 100644) com conteúdo idêntico ao AGENTS.md. Com o tempo os dois vão divergir. O correto:

rm CLAUDE.md
ln -s AGENTS.md CLAUDE.md
git add CLAUDE.md

O diff deveria mostrar mode 120000 com conteúdo AGENTS.md.


🟡 Symlinks auto-referenciais em .agents/

Os arquivos .agents/commands/commands, .agents/rules/rules e .agents/skills/skills apontam cada um para o próprio diretório pai. São loops circulares que podem causar comportamento inesperado em ferramentas que percorrem o diretório recursivamente. Remover os três.


🟡 AGENTS.md não declara MCPs esperados

Para um repo com consumidores externos (vtex.omnishipping, vtex.shipping-preview), seria útil indicar o GitHub MCP para busca cross-repo antes de breaking changes — conforme recomendado no guia para AGENTS.md detailed.

@lucvysk
Copy link
Copy Markdown
Contributor Author

lucvysk commented May 14, 2026

CLAUDE.md deve ser symlink, não cópia

done

@sonar-workflows
Copy link
Copy Markdown

Failed Quality Gate failed

  • 4.35% Duplicated Lines (%) on New Code (is greater than 3.00%)

Project ID: address-form

View in SonarQube

@lucvysk lucvysk merged commit ec0e891 into main May 14, 2026
21 of 31 checks passed
@lucvysk lucvysk deleted the feat/ai-standards branch May 14, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants