Skip to content

env variable for disabling fs cache - #72

Merged
vnmabus merged 4 commits into
vnmabus:developfrom
the-pawel-wojcik:optional-fs-cache
Aug 21, 2026
Merged

env variable for disabling fs cache#72
vnmabus merged 4 commits into
vnmabus:developfrom
the-pawel-wojcik:optional-fs-cache

Conversation

@the-pawel-wojcik

Copy link
Copy Markdown
Contributor

References to issues or other PRs

Quick change. No issues opened. I am fighting through the filesystem cache that numba generates. I would like to have it disabled. Please merge if you don't mind. Currently it's a hardcoded yes that cannot be configured.

Describe the proposed changes

Add an env var DCOR_DISABLE_FS_CACHE. When set the filesystem cache is disabled.

Additional information

None

Checklist before requesting a review

  • I have performed a self-review of my code
  • [?] The code conforms to the style used in this package
  • The code is fully documented and typed (type-checked with Mypy)
  • [-] I have added thorough tests for the new/changed functionality

@the-pawel-wojcik

Copy link
Copy Markdown
Contributor Author

Here is more context
numba/numba#4549

@vnmabus

vnmabus commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Thanks for your contribution!

I saw that the documentation was failing for unrelated causes, so I added a patch to develop. Please rebase/merge develop to see if all tests pass now.

The changes themselves seem good. It is unfortunate that there is no "standard" way to do this, not even a recommended environment variable that we can try to honor.

The only nitpick I have is that I think it would be better to have the logic to set FS_CACHE in one place (maybe in _utils?), so that the definitions do not go out-of-sync. Could you please make that change?

@the-pawel-wojcik

Copy link
Copy Markdown
Contributor Author

fixed. thank you!

@vnmabus
vnmabus merged commit 20c9f18 into vnmabus:develop Aug 21, 2026
13 checks passed
@vnmabus

vnmabus commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Thanks for your contribution!

@all-contributors Add @the-pawel-wojcik for code

@allcontributors

Copy link
Copy Markdown
Contributor

@vnmabus

I've put up a pull request to add @the-pawel-wojcik! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants