fix: accept notion data source parent webhooks#20709
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
|
API preview: https://pr-20709-api.vm6.ai |
…tem-webhook-parent
Contributor
Author
|
LGTM PR_AUTO_REVIEW_COMMIT: 2584dfb SummaryThis PR accepts the Notion 2026 database item webhook parent shape where data.parent includes data_source_id without a type field. The routing logic now treats data_source_id as the data source parent, while page-parent matching skips those events so database item creates do not get misclassified as child-page events. FindingsCritical (P0)
High Priority (P1)
Testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data_source_idwithout atypefield.data.parent.data_source_idwhen present.page.createddatabase item shape.Context
While validating the
notion-database-item-createdworkflow trigger, Notion sentpage.createdwebhook payloads for database items using the official 2026 shape:data.parentincludesidanddata_source_id, but notype. The previous schema requiredparent.type, causing these events to be rejected before they could enqueue the workflow event.Verification
pnpm --dir turbo/apps/api test src/signals/routes/__tests__/webhooks-notion.test.tsnode_modulesis missing in this checkout (vitest: not found). CI should run the targeted suite with installed dependencies.