fix: require visible chat output before callback delivery#20704
Closed
seven332 wants to merge 26 commits into
Closed
fix: require visible chat output before callback delivery#20704seven332 wants to merge 26 commits into
seven332 wants to merge 26 commits into
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
|
API preview: https://pr-20704-api.vm6.ai |
This was referenced Jul 8, 2026
d2f2d9b to
26298d0
Compare
Contributor
Author
|
Closing per maintainer decision; this approach will not be pursued. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #20643
Verification
pnpm -F api exec vitest run src/signals/routes/__tests__/internal-callbacks-teams.test.tspnpm -F api exec vitest run src/signals/routes/__tests__/internal-callbacks-telegram.test.tspnpm -F api exec vitest run src/signals/routes/__tests__/agentphone.bdd.test.tspnpm -F api exec vitest run src/signals/routes/__tests__/integrations.bdd.test.ts -t "waits for Slack completed output|delivers Slack org callbacks"pnpm -F api exec vitest run src/signals/routes/__tests__/integrations.bdd.test.ts -t "runs Slack mentions|starts a new Slack session"pnpm -F api lintpnpm -F api check-typespnpm knip --cacheturbo run check-types --concurrency=1