fix: reconcile usage allowance subscriptions#20684
Conversation
8631b9f to
3cae5da
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
API preview: https://pr-20684-api.vm6.ai |
b5130b2 to
17dcdc4
Compare
17dcdc4 to
5c2a11f
Compare
Code Review: PR #20684 (Round 1) - LGTMSummaryReviewed the usage allowance billing changes after resolving the rebase conflict. I found and fixed one high-priority allowance eligibility edge case before posting this review: settlement/firewall allowance lookup now requires the run to be a vm0 run and reads windows issued for the run creation time, so canceled entitlements still honor already-created runs while non-vm0 runs inside active windows do not consume vm0 allowance. Testing ReviewCoverage now includes:
Verification
Verdict: LGTMNo remaining P0/P1 issues found. Completed after 1 round of automated review-fix loop |
Summary
Tests