Fix ANSI hyperlink parsing and cursor positioning#13
Merged
vito merged 1 commit intovito:masterfrom Oct 28, 2025
Merged
Conversation
Contributor
analytically
commented
Oct 28, 2025
analytically
commented
- Fix hyperlink URL parsing to preserve semicolons in URLs by only splitting on first two semicolons
- Fix non-ASCII character encoding in URLs to encode individual characters rather than entire string
- Fix CursorColumn (CSI G) to use 1-based indexing as per ANSI spec
- Fix EraseToBeginning to not preserve hyperlinks in erased content
- Remove OSC backslash terminator support (ESC+)
- Update elm-explorations/test to 2.2.0
- Add comprehensive test coverage for URL edge cases and erase behavior
- Update yarn.lock to v2/v3 format
- Fix hyperlink URL parsing to preserve semicolons in URLs by only splitting on first two semicolons - Fix non-ASCII character encoding in URLs to encode individual characters rather than entire string - Fix CursorColumn (CSI G) to use 1-based indexing as per ANSI spec - Fix EraseToBeginning to not preserve hyperlinks in erased content - Remove OSC backslash terminator support (ESC+\) - Update elm-explorations/test to 2.2.0 - Add comprehensive test coverage for URL edge cases and erase behavior - Update yarn.lock to v2/v3 format Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
Contributor
Author
Contributor
Author
|
CSI G bug: ESC[nG wasn't converting from 1-based (ANSI) to 0-based (internal) indexing, causing cursor to be 1 column too far right. Rare in practice - most tools use other cursor commands. |
Owner
|
Thanks! |
Owner
|
(Will cut a release soon, gotta walk the dog first) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.