perf(vm): let environments opt out of the module graph prewarm - #11078
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
@hi-ogawa you were right! |
hi-ogawa
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vm pool prewarm from #10744 only pays off while the server is idle during a slow
setupVM(jsdom, happy-dom). With thenodeenvironment there is no such window, so the walk competes with the worker's own fetches: on the benchmarks'micro-utilsapp (5 files) warmvmThreadswent from 0.27s on 4.1.10 to 0.33s,node-libraryfrom 0.53s to 0.55s.Adds
prewarmModules?: booleantoEnvironment(defaulttrue) and sets it tofalseon the built-innodeenvironment. Custom environments with a cheapsetupVMcan opt out the same way.Warm medians on micro-utils after the change, 4.1.10 vs this PR:
vmThreads0.28s vs 0.28s,vmForks0.29s vs 0.29s,vmThreads+ jsdom 0.61s vs 0.56s (prewarm still on). node-libraryvmThreads0.53s vs 0.49s.