Skip to content

fix(ui): persist authentication cookie beyond current browser session #11066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hi-ogawa wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Draft

fix(ui): persist authentication cookie beyond current browser session #11066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/ui/node/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { distClientRoot } from './paths'
export { distClientRoot }

const UI_TOKEN_COOKIE = 'vitest-ui-token'
const UI_TOKEN_COOKIE_MAX_AGE = 60 * 60 * 24 * 365
const AUTH_REQUIRED_MESSAGE = 'Vitest UI requires authentication. Open the URL with the token printed in the terminal, e.g. http://localhost:51204/__vitest__/?token=...'

export default (harness: PluginHarness): Vite.Plugin => {
Expand Down Expand Up @@ -40,6 +41,7 @@ export default (harness: PluginHarness): Vite.Plugin => {
return serializeCookie(UI_TOKEN_COOKIE, ctx.config.api.token, {
path: base,
httpOnly: true,
maxAge: UI_TOKEN_COOKIE_MAX_AGE,
sameSite: 'strict',
})
}
Expand Down
10 changes: 10 additions & 0 deletions test/ui/test/ui.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,16 @@ test.describe('ui', () => {
await assertTestCounts(page, { pass: TEST_COUNTS.pass, fail: TEST_COUNTS.fail })
expect(page.url()).toBe(`${cleanPageUrl}#/`)

const tokenCookie = (await page.context().cookies(cleanPageUrl))
.find(cookie => cookie.name === 'vitest-ui-token')
expect(tokenCookie).toMatchObject({
httpOnly: true,
sameSite: 'Strict',
})
expect(tokenCookie!.expires).toBeGreaterThan(
Date.now() / 1000 + 60 * 60 * 24 * 364,
)

await page.goto(cleanPageUrl)
await assertTestCounts(page, { pass: TEST_COUNTS.pass, fail: TEST_COUNTS.fail })
expect(page.url()).toBe(`${cleanPageUrl}#/`)
Expand Down
Loading