Skip to content

fix(ui): handle suite report navigation - #11038

Open
dvmhmdsd wants to merge 4 commits into
vitest-dev:mainfrom
dvmhmdsd:fix/issue-10973-suite-report
Open

fix(ui): handle suite report navigation#11038
dvmhmdsd wants to merge 4 commits into
vitest-dev:mainfrom
dvmhmdsd:fix/issue-10973-suite-report

Conversation

@dvmhmdsd

Copy link
Copy Markdown
Contributor

Description

Resolves #10973

Suite source navigation stores the suite ID as the selected task. The report view previously treated every selected task as a test case, causing suite selections to fail while rendering test-only fields.

Only actual test tasks are now passed to the test report. Suite selections fall back to the file-level report.
image

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • PR title is prefixed with the correct type.

@netlify

netlify Bot commented Aug 23, 2026

Copy link
Copy Markdown

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 07dd360
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6a9296b8032ea300087978ab
😎 Deploy Preview https://deploy-preview-11038--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa hi-ogawa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suite selections fall back to the file-level report.

Is this only way? Like can we somehow show suite (and/or its children) results?

@dvmhmdsd

Copy link
Copy Markdown
Contributor Author

@hi-ogawa Good point, I fell back to file-level report bcz ViewReport only accepted files, and it was the simplest way to avoid incorrectly treating the selected suite as a test
However, I think it's possible to let ViewReport accept a suite and show its own errors and failed children recursively.

@dvmhmdsd
dvmhmdsd requested a review from hi-ogawa August 24, 2026 03:44
@hi-ogawa hi-ogawa self-assigned this Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI report tab is empty when navigated after "View suite source code"

2 participants