Skip to content

fix(ui): persist trace step-iframe split pane sizes - #11027

Open
hi-ogawa wants to merge 47 commits into
vitest-dev:mainfrom
hi-ogawa:feat/trace-split-persistence
Open

fix(ui): persist trace step-iframe split pane sizes#11027
hi-ogawa wants to merge 47 commits into
vitest-dev:mainfrom
hi-ogawa:feat/trace-split-persistence

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Description

This is a final missing piece to make trace view stable after reload.

Demo from https://github.com/vitest-dev/vitest/actions/runs/32683521351/job/97305462075?pr=11027

Screen.Recording.2026-08-24.at.11.45.30.mov

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

hi-ogawa and others added 30 commits August 18, 2026 15:08
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
hi-ogawa and others added 3 commits August 21, 2026 14:59
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
@hi-ogawa hi-ogawa changed the title fix(ui): persist trace pane sizes fix(ui): persist trace step/iframe split pane sizes Aug 21, 2026
@netlify

netlify Bot commented Aug 21, 2026

Copy link
Copy Markdown

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 045da8d
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6a8817ba8cf5570008267b40
😎 Deploy Preview https://deploy-preview-11027--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa and others added 14 commits August 24, 2026 10:28
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
@hi-ogawa
hi-ogawa marked this pull request as ready for review August 24, 2026 02:34
@hi-ogawa hi-ogawa changed the title fix(ui): persist trace step/iframe split pane sizes fix(ui): persist trace step-iframe split pane sizes Aug 24, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 24, 2026

Copy link
Copy Markdown
@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@c36c4fd

@vitest/browser-playwright

npm i https://pkg.pr.new/@vitest/browser-playwright@c36c4fd

@vitest/browser-preview

npm i https://pkg.pr.new/@vitest/browser-preview@c36c4fd

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@c36c4fd

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@c36c4fd

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@c36c4fd

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@c36c4fd

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@c36c4fd

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@c36c4fd

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@c36c4fd

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@c36c4fd

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@c36c4fd

vitest

npm i https://pkg.pr.new/vitest@c36c4fd

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@c36c4fd

commit: c36c4fd

67,
],
)
export const traceViewSplitSizes = useLocalStorage<[steps: number, iframe: number]>(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local storage is not persistent between different runs, is it? we also have the same issue with dark mode. these settings should probably be also stored on the device somewhere

not blocking though

@sheremet-va

Copy link
Copy Markdown
Member

Conflict! 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants