fix(server): queue restarts requested during restart (fix #23392) - #23402
Open
QuarkOS wants to merge 1 commit into
Open
fix(server): queue restarts requested during restart (fix #23392)#23402QuarkOS wants to merge 1 commit into
QuarkOS wants to merge 1 commit into
Conversation
Coalesce restart() calls that arrive while a restart is already in flight so the server converges to the latest config on disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #23392
If vite.config changes while a restart is already running, the extra restart gets ignored. We keep serving the old config until the file is touched again.
We remember that a restart was requested, run one more after the current one finishes, and keep that when Vite swaps in the new server.
the restart.spec test holds the first restart, asks for more, and checks that exactly one follow-up runs.
Windows CI failed on a different HMR playground test. This restart test passed.
I used an agent for the first patch. I read the restart queue and the test before opening this.