feat(config): warn on named imports from JSON modules - #23378
Open
btea wants to merge 4 commits into
Open
Conversation
Member
|
Technically this isn't correct as no named export exist per spec. |
Contributor
Author
|
Thank you for the detailed explanation; I only just learned about this standard. It seems the current configLoader method is causing it to parse successfully. Perhaps we should add syntax validation warnings to nativeConfigCompat.ts to address this situation. |
Member
|
Adding a compat warning sounds nice to me 👍 |
Contributor
Author
|
Okay, I'll adjust it directly in this PR. |
btea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the version field in package.json is used, so we can import it directly.