Skip to content

docs: correct anchor scroll offset after dismissing top banner #23366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btea wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: correct anchor scroll offset after dismissing top banner #23366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions docs/.vitepress/theme/components/TopBanner.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,28 @@ function dismiss() {

@media (min-width: 768px) {
.top-banner {
--vp-banner-height: 40px;
--vp-banner-height: var(--top-banner-height);
}

:root:has(.top-banner):not(.banner-dismissed) {
--vp-banner-height: 40px;
--vp-banner-height: var(--top-banner-height);
}
}

:root:has(.top-banner) {
--top-banner-height: 40px;
}

/* When the banner is dismissed the fixed header moves up by the banner
height, so tighten the anchor scroll offset by the same amount to keep
the landing position visually identical. .top-banner stays in the DOM
(hidden) after dismissal, so :has() still matches. */
@media (min-width: 1024px) {
:root:has(.top-banner).banner-dismissed .vp-doc :is(h1, h2, h3, h4, h5, h6) {
scroll-margin-top: calc(
var(--vp-nav-height) + var(--vp-layout-top-height, 0px) + 24px -
var(--top-banner-height)
);
}
}
</style>
Loading