Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 88 additions & 0 deletions packages/vite/src/node/__tests__/build.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1115,6 +1115,94 @@ test('chunkImportMap per environment with shared plugins', async () => {
expect(entry.code).toContain(JSON.stringify(cssSpecifier.slice(1)))
})

test('chunkImportMap preserves module preload deps when base is not / (fix #23350)', async () => {
const root = resolve(dirname, 'fixtures/shared-plugins/chunk-import-map')
const builder = await createBuilder({
root,
base: '/sub/',
logLevel: 'warn',
environments: {
client: {
build: {
chunkImportMap: true,
write: false,
rolldownOptions: {
input: '/entry.js',
},
},
},
},
})

const result = (await builder.build(
builder.environments.client,
)) as RolldownOutput

const entry = result.output.find(
(output): output is OutputChunk =>
output.type === 'chunk' && output.isEntry,
)!
const css = result.output.find(
(output) => output.type === 'asset' && output.fileName.endsWith('.css'),
)!
const importMapAsset = result.output.find(
(output): output is OutputAsset =>
output.type === 'asset' && output.fileName === 'importmap.json',
)!
const importMap = JSON.parse(importMapAsset.source.toString())
.imports as Record<string, string>
const cssSpecifier = Object.entries(importMap).find(
([, fileName]) => fileName === `/sub/${css.fileName}`,
)![0]
expect(entry.code).toContain(
JSON.stringify(cssSpecifier.slice('/sub/'.length)),
)
})

test('chunkImportMap preserves module preload deps when base is ./', async () => {
const root = resolve(dirname, 'fixtures/shared-plugins/chunk-import-map')
const builder = await createBuilder({
root,
base: './',
logLevel: 'warn',
environments: {
client: {
build: {
chunkImportMap: true,
write: false,
rolldownOptions: {
input: '/entry.js',
},
},
},
},
})

const result = (await builder.build(
builder.environments.client,
)) as RolldownOutput

const entry = result.output.find(
(output): output is OutputChunk =>
output.type === 'chunk' && output.isEntry,
)!
const css = result.output.find(
(output) => output.type === 'asset' && output.fileName.endsWith('.css'),
)!
const importMapAsset = result.output.find(
(output): output is OutputAsset =>
output.type === 'asset' && output.fileName === 'importmap.json',
)!
const importMap = JSON.parse(importMapAsset.source.toString())
.imports as Record<string, string>
const cssSpecifier = Object.entries(importMap).find(
([, fileName]) => fileName === `./${css.fileName}`,
)![0]
expect(entry.code).toContain(
JSON.stringify(`./${cssSpecifier.slice('./assets/'.length)}`),
)
})

test('chunkImportMap is emitted when emitAssets is false', async () => {
const root = resolve(dirname, 'fixtures/shared-plugins/chunk-import-map')
const builder = await createBuilder({
Expand Down
6 changes: 4 additions & 2 deletions packages/vite/src/node/plugins/html.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1700,13 +1700,15 @@ export function getImportMapFilename(
return 'importmap.json'
}

function getImportMapBaseUrl(options: ResolvedEnvironmentOptions): string {
function getImportMapBaseUrl(
options: ResolvedEnvironmentOptions & { base?: string },
): string {
const chunkImportMap =
options.build.rolldownOptions.experimental?.chunkImportMap
if (typeof chunkImportMap === 'object' && chunkImportMap.baseUrl) {
return chunkImportMap.baseUrl
}
return '/'
return options.base ?? '/'
}

/**
Expand Down
Loading