fix: inject browser hash into node_modules module scripts - #23343
Open
ddddajie wants to merge 3 commits into
Open
fix: inject browser hash into node_modules module scripts#23343ddddajie wants to merge 3 commits into
ddddajie wants to merge 3 commits into
Conversation
Author
|
CI is currently failing on two unrelated tests: macOS: playground/css-codesplit/tests/css-codesplit.spec.ts The regression test added by this PR passes in the CI runs, and the Ubuntu Node 20/22/24/26 jobs are all green. I don't have permission to re-run the failed jobs. Could a maintainer please re-run them when convenient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9828.
Module scripts that directly reference files in
node_modulesdid not receive the dependency optimizer's browser hash, while imports of the same module through JavaScript did.This caused the browser to see two different module URLs and instantiate the module twice.
This PR injects the current
browserHashinto eligiblenode_modulesmodule script URLs during dev HTML processing, before pre-transform and module graph handling.Public files, classic scripts, external/data URLs, and existing version queries are left unchanged.
Tests
Added a regression test that loads the same excluded dependency through both an HTML module script and a JavaScript import and verifies that it is instantiated only once.
Local checks passed:
indexHtmlunit testsgit diff --checkThe targeted optimize-deps browser test could not run locally because the Windows environment could not create the playground junction.