fix(react): make logging diagnostics an opt-in for React Compiler - #1431
Merged
sapphi-red merged 4 commits intoAug 28, 2026
Conversation
dqbd
marked this pull request as draft
August 21, 2026 12:42
dqbd
marked this pull request as ready for review
August 21, 2026 12:46
ArnaudBarre
reviewed
Aug 21, 2026
Member
|
Thanks for the update! Can you document this new option on the readme and add a changelog entry? |
Contributor
Author
|
Added, thank you @ArnaudBarre! |
ArnaudBarre
approved these changes
Aug 25, 2026
Member
Given that the babel plugin (and Next.js) doesn't emit these logs, I think we can skip these by default. |
sapphi-red
changed the title
sapphi-red
reviewed
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When Rust React Compiler is enabled in
@vite/plugin-react@6.1.0, the plugin emits a Vite warning for every recoverable diagnostic, making the console output unnecessarily verbose.This PR moves the diagnostics logging behind a
logDiagnosticsplugin option, with the option being disabled by default.