Deduplicate ctypes, fix docs.rs and other small improvements#32
Draft
Deduplicate ctypes, fix docs.rs and other small improvements#32
Conversation
pheki
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most important commits:
Use ctypes definitions from core: I don't expect any of these to ever change again, but I think it's better to deduplicate as they aren't really required anymore.
Replace doc_auto_cfg with doc_cfg:
doc_auto_cfgwas merged intodoc_cfgin rust-lang/rust#138907, but unfortunately it's not working correctly for our use-case due to rust-lang/rust#150268. Marking this as a draft to see if that issue gets resolved in a timely manner, otherwise we can look into moving thecfgblocks to the inside of theexternblocks.