Skip to content

Fixing failing CI/CD #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rayman2000 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing failing CI/CD #342

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d59280
some ideas
rayman2000 Mar 5, 2026
4c5360f
restored comments
rayman2000 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/main/scala/viper/server/vsi/VerificationServer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,6 @@ trait VerificationServer extends Post {

}).recover({
case e: AstConstructionException =>
// If the AST construction phase failed, remove the verification job handle
Comment thread
rayman2000 marked this conversation as resolved.
// from the corresponding pool.
val msg = s"AST construction job ${prev_job_id_maybe.get} resulted in a failure: $e"
println(msg)
pool.discardJob(new_jid)
Expand Down Expand Up @@ -239,9 +237,12 @@ trait VerificationServer extends Post {
val resulting_source = combined_source.map(e => unpack(e))
resulting_source.runWith(sink)

// FIXME This assumes that someone will actually complete the verification job queue.
// FIXME Could we guarantee that the client won't forget to do this?
ver_handle.queue.watchCompletion()
ver_handle match {
case VerHandle(null, null, null, _) =>
Future.successful(Done)
case _ =>
ver_handle.queue.watchCompletion()
}
})
}
}
Expand Down Expand Up @@ -299,8 +300,13 @@ trait VerificationServer extends Post {
handle_future.flatMap {
case AstHandle(actor, _, _, _) =>
(actor ? VerificationProtocol.StopAstConstruction).mapTo[String]
case VerHandle(null, _, _, _) =>
Future.successful("Job had no actor.")
case VerHandle(actor, _, _, _) =>
(actor ? VerificationProtocol.StopVerification).mapTo[String]
Comment thread
rayman2000 marked this conversation as resolved.
}.recover {
case _: akka.pattern.AskTimeoutException =>
"Job actor already terminated."
}
} toList
val overall_interrupt_future: Future[List[String]] = Future.sequence(interrupt_future_list)
Expand Down