Fix startup crash on Python 3.14 (Removal of pkgutil.find_loader)#407
Open
Geetansh-Jangid wants to merge 1 commit intovinifmor:masterfrom
Open
Fix startup crash on Python 3.14 (Removal of pkgutil.find_loader)#407Geetansh-Jangid wants to merge 1 commit intovinifmor:masterfrom
Geetansh-Jangid wants to merge 1 commit intovinifmor:masterfrom
Conversation
As of Python 3.14, the long-deprecated pkgutil.find_loader() has been officially removed from the standard library. This causes bauh to fail immediately on startup with an AttributeError.
The Fix :-
This PR migrates the dynamic module loading logic in gems.py to the modern importlib.util API, which is the standard replacement for pkgutil and imp.
Replaced pkgutil.find_loader with importlib.util.find_spec.
Standardized Indentation: Fixed a TabError (mixed tabs/spaces) introduced in the load_managers loop.
Updated Module Loading: Used spec.loader.load_module() to ensure the controller modules are initialized correctly under the new spec-based system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Python 3.14, the long-deprecated pkgutil.find_loader() has been officially removed from the standard library. This causes bauh to fail immediately on startup with an AttributeError.
The Fix :-
This PR migrates the dynamic module loading logic in gems.py to the modern importlib.util API, which is the standard replacement for pkgutil and imp.