Repository navigation
Guard authenticate() entry point against exceptions - #11
Merged
Merged
Conversation
authenticate() itself (renamed authenticate_impl) had no try/catch around its own body, even though the JWT-parsing/signature-verification/ regex/JWKS-JSON helpers it calls (evaluate(), map_roles(), JwksCache) already guard themselves. The uncaught paths were in authenticate()'s own body: std::string construction from the raw handshake packet, build_config()/build_key_resolver()'s std::function/std::string copies, and the two std::vector<const char*> role-pointer buffers -- all can throw std::bad_alloc under memory pressure. VEF does not catch exceptions at the preview/auth entry-point boundary, so an escaping exception here crashes the whole server rather than just failing the one login. Added a thin authenticate() wrapper around authenticate_impl that fails closed (AuthResult::kError) on any exception, consistent with every other rejection path already in this function. AI=CLAUDE Co-Authored-By: Claude <claude-opus-4-6@noreply.anthropic.com>
tomas-villagesql
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing exception handling.
AI=CLAUDE