Skip to content

fix: correct PAT section_number and last_section_number offsets #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpruijsen wants to merge 1 commit into from
Closed

fix: correct PAT section_number and last_section_number offsets #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/m2ts/m2ts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ TransportParseStream = function() {
};

parsePat = function(payload, pat) {
pat.section_number = payload[7]; // eslint-disable-line camelcase
pat.last_section_number = payload[8]; // eslint-disable-line camelcase
pat.section_number = payload[6]; // eslint-disable-line camelcase
pat.last_section_number = payload[7]; // eslint-disable-line camelcase

// skip the PSI header and parse the first PMT entry
self.pmtPid = (payload[10] & 0x1F) << 8 | payload[11];
Expand Down
20 changes: 20 additions & 0 deletions test/transmuxer.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,26 @@ QUnit.test('parses the program map table pid from the program association table
assert.strictEqual(0x0010, transportParseStream.pmtPid, 'parsed PMT pid');
});

QUnit.test('parses section_number and last_section_number from the PAT', function(assert) {
var packet, pat;

// Distinctive values: the shared PAT fixture is zero here, which hides
// an off-by-one against program_number (ISO/IEC 13818-1 2.4.4.3).
pat = PAT.slice();
pat[11] = 0x03;
pat[12] = 0x05;

transportParseStream.on('data', function(data) {
packet = data;
});

transportParseStream.push(new Uint8Array(pat));
assert.ok(packet, 'parsed a packet');
assert.strictEqual(packet.section_number, 0x03, 'parsed section_number'); // eslint-disable-line camelcase
assert.strictEqual(packet.last_section_number, 0x05, 'parsed last_section_number'); // eslint-disable-line camelcase
assert.strictEqual(packet.pmtPid, 0x0010, 'parsed PMT pid');
});

QUnit.test('does not parse PES packets until after the PES has been parsed', function(assert) {
var pesCount = 0;

Expand Down