APP-16852: added UploadDataFromPath protos#864
Open
angelapredolac wants to merge 5 commits into
Open
Conversation
gloriacai01
reviewed
Jun 9, 2026
gloriacai01
left a comment
Member
There was a problem hiding this comment.
overall looks good! my only nit is if we could add comments for each field as specified in the scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Ticket: Add UploadDataFromPath protos
Summary
The data manager could only upload arbitrary files on its configured sync interval — there was no way to push an existing file or directory to the cloud ad hoc. This adds a new UploadDataFromPath RPC to the RobotService, exposing push-based binary file uploads on the robot. A caller provides a file or directory path (and optional metadata), and the robot routes the upload through its configured data manager service. This PR is the protobuf-only first step; the server/client implementation lands in rdk #5917, and SDK wrappers follow.
Changes
Testing