remove box_syntax

[seeplusplus]

Description

Box syntax removed in rust-lang/rust#108471

Removed all #![features(box_syntax)] and ran cargo fix --broken-code to replace all previous box_patterns uses of box with Box::new().

Testing Instructions

No testing needed.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-designsystem-docs	🔄 Building (Inspect)	Visit Preview		Apr 26, 2023 0:20am
examples-kitchensink-blog	🔄 Building (Inspect)	Visit Preview		Apr 26, 2023 0:20am

7 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview		Apr 26, 2023 0:20am
examples-cra-web	⬜️ Ignored (Inspect)	Visit Preview		Apr 26, 2023 0:20am
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview		Apr 26, 2023 0:20am
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview		Apr 26, 2023 0:20am
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview		Apr 26, 2023 0:20am
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview		Apr 26, 2023 0:20am
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview		Apr 26, 2023 0:20am

[vercel]

@seeplusplus is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

[sokra]

You missed a bunch of cases where it's used: https://github.com/vercel/turbo/actions/runs/4762414719/jobs/8466543730?pr=4667

[seeplusplus]

You missed a bunch of cases where it's used: https://github.com/vercel/turbo/actions/runs/4762414719/jobs/8466543730?pr=4667

I'll get this knocked out these evening, thanks!

Edit

I have fixed the 6 instances I missed. I also found out why I missed them, the following line
https://github.com/vercel/turbo/blob/main/crates/turbopack-ecmascript/src/parse.rs#L209

causes issues in my editor/when I try to compile on rust nightly 1.70.0 and 1.71.0.

error[E0282]: type annotations needed for `Pin<&mut F>`
   --> crates/turbopack-ecmascript/src/parse.rs:209:10
    |
209 |         |f, cx| {
    |          ^
210 |             GLOBALS.set(globals_ref, || {
211 |                 HANDLER.set(&handler, || HELPERS.set(&helpers, || f.poll(cx)))
    |                                                                     ---- type must be known at this point
    |
help: consider giving this closure parameter an explicit type, where the type for type parameter `F` is specified
    |
209 |         |f: Pin<&mut F>, cx| {
    |           +++++++++++++

The only way I was able to resolve this was to yank the async{} block that starts below into a variable definition above the WrapFuture call here and use that var instead. Once that was fixed I could run cargo build --broken-code again and the rest of the box references were fixed. I pushed just the Box changes, but not the changes to WrapFuture, since I'm not sure if this was the "correct" fix.

I don't know why RLS/the compiler cares about this/can't infer the types without this change. Undoubtedly, there's some type def that will make this work, but I tried various combinations of Pin/Futures/Poll (e.g., |f: Pin<&mut Future<Poll<...>>) and couldn't get the right type. I could use some help with this if it's necessary (waiting to see if it compiles in the GH Action).

[seeplusplus]

@sokra I think I've fixed all those issues, though I don't have permissions to rerun the GH Action to build the crates. Could you rerun those?

[jridgewell]

Thanks for the help!