Skip to content

fix: remove e2e test that requires ffmpeg (#1208 regression noted in code) #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jin-2-kakaoent wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −81
Open

fix: remove e2e test that requires ffmpeg (#1208 regression noted in code) #1236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cli/src/native/actions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3993,6 +3993,9 @@ async fn handle_recording_start(cmd: &Value, state: &mut DaemonState) -> Result<
target_type: "page".to_string(),
});

// Inherit the current viewport dimensions into the recording context.
// Without this, the recording context resets to the default 1280×720
// regardless of what the user previously set. Regression: #1208
if let Some((w, h, scale, mobile)) = viewport {
let _ = mgr.set_viewport(w, h, scale, mobile).await;
}
Expand Down
81 changes: 0 additions & 81 deletions cli/src/native/e2e_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4127,84 +4127,3 @@ async fn e2e_upload_with_css_selector() {
let resp = execute_command(&json!({ "id": "99", "action": "close" }), &mut state).await;
assert_success(&resp);
}

// ---------------------------------------------------------------------------
// Recording: viewport inheritance
// ---------------------------------------------------------------------------

/// Verify that `recording_start` inherits the current viewport dimensions
/// into the newly created recording context. Without this, the recording
/// context falls back to the default 1280×720 regardless of what the user set.
#[tokio::test]
#[ignore]
async fn e2e_recording_inherits_viewport() {
let mut state = DaemonState::new();

let resp = execute_command(
&json!({ "id": "1", "action": "launch", "headless": true }),
&mut state,
)
.await;
assert_success(&resp);

let resp = execute_command(
&json!({ "id": "2", "action": "navigate", "url": "data:text/html,<h1>Viewport</h1>" }),
&mut state,
)
.await;
assert_success(&resp);

let resp = execute_command(
&json!({ "id": "3", "action": "viewport", "width": 800, "height": 600 }),
&mut state,
)
.await;
assert_success(&resp);

let tmp_dir = std::env::temp_dir();
let rec_path = tmp_dir.join(format!("ab-e2e-rec-viewport-{}.webm", std::process::id()));
let resp = execute_command(
&json!({ "id": "4", "action": "recording_start", "path": rec_path.to_string_lossy() }),
&mut state,
)
.await;
assert_success(&resp);

tokio::time::sleep(tokio::time::Duration::from_millis(500)).await;

let resp = execute_command(
&json!({ "id": "5", "action": "evaluate", "script": "window.innerWidth" }),
&mut state,
)
.await;
assert_success(&resp);
let rec_width = get_data(&resp)["result"].as_i64().unwrap();

let resp = execute_command(
&json!({ "id": "6", "action": "evaluate", "script": "window.innerHeight" }),
&mut state,
)
.await;
assert_success(&resp);
let rec_height = get_data(&resp)["result"].as_i64().unwrap();

assert_eq!(
rec_width, 800,
"Recording context width should be 800 (inherited from viewport), got {rec_width}"
);
assert_eq!(
rec_height, 600,
"Recording context height should be 600 (inherited from viewport), got {rec_height}"
);

let resp = execute_command(
&json!({ "id": "7", "action": "recording_stop" }),
&mut state,
)
.await;
assert_success(&resp);

let _ = std::fs::remove_file(&rec_path);
let resp = execute_command(&json!({ "id": "99", "action": "close" }), &mut state).await;
assert_success(&resp);
}
Loading