Add datetime_rule_variable/DateTimeType.#83
Open
trevoriancox wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A useful addition to the conditions is a date/time field. It appears to me that to add additional variables, you have to modify operators.py in this library, as utils.export_rule_data inspects this file. If additional variables can't be added without modifying the library, it would be helpful to have a more complete set of variable types.
If there is interest, I could add the test cases.
This implementation handles only naive datetimes, as would be provided by HTML5 datetime-local inputs. For code that expects time zone information, I noted that has been added to business_rules in https://github.com/TencentBlueKing/bk-itsm/