Add Singapore Exchange (SGX) holidays by pareshjoshij · Pull Request #3719 · vacanza/holidays

pareshjoshij · 2026-07-25T15:12:45Z

This PR adds the holidays for the Singapore Exchange (SGX) financial calendar and l10n support.
Part of GSoC (#3424)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

coderabbitai · 2026-07-25T15:13:03Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 942b7fd9-43f5-40c4-9197-ade6c051f139

📥 Commits

Reviewing files that changed from the base of the PR and between c0743b5 and 329a4ec.

📒 Files selected for processing (3)

holidays/financial/singapore_exchange.py
holidays/locale/th/LC_MESSAGES/XSES.po
tests/financial/test_singapore_exchange.py

Summary by CodeRabbit

New Features
- Added Singapore Exchange (SGX) holiday calendar support, including full-day market holidays and half-day closures for Christmas Eve, New Year’s Eve, and Chinese New Year’s Eve (market closes at 12:00 p.m. SGT).
- Made the calendar available via the SGX identifiers.
- Added localized holiday labels for Singapore English (en_SG/en_US) and Thai (th).
Documentation
- Updated the available financial markets list to include Singapore Exchange (SGX).
Tests
- Added coverage for SGX holiday rules and localization.

Walkthrough

Adds Singapore Exchange holiday support with weekend-adjusted public holidays, Christmas Eve, New Year’s Eve, and Chinese New Year’s Eve half-days. Registers SingaporeExchange, XSES, and SGX, adds translations and documentation, and introduces comprehensive tests.

Changes

Singapore Exchange holidays

Layer / File(s)	Summary
SGX holiday rules `holidays/financial/singapore_exchange.py`	Defines SGX public-holiday filtering, half-day entries, market-close labels, and `XSES`/`SGX` aliases.
Exchange registration and messages `holidays/financial/__init__.py`, `holidays/registry.py`, `README.md`, `holidays/locale/.../XSES.po`	Exports and registers the exchange codes, documents SGX, and adds English and Thai message catalogs.
Holiday behavior tests `tests/financial/test_singapore_exchange.py`	Validates exchange metadata, observed half-days, localization, and 2025 full-day and half-day holiday sets.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

vacanza/holidays#3170: Adds another financial exchange through the same registry and export integration points.
vacanza/holidays#3654: Wires another exchange through the shared financial exports and registry.
vacanza/holidays#3714: Adds similar financial-market half-day rules and integration updates.

Suggested reviewers: arkid15r, kjhellico

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: adding Singapore Exchange (SGX) holiday support.
Description check	✅ Passed	The description is directly related and accurately summarizes the new SGX holidays and l10n support.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

cubic-dev-ai

1 issue found across 8 files

Confidence score: 4/5

In holidays/financial/singapore_exchange.py, weekend special closures can be added after the weekend-filtering loop, so dates like Saturday 2025-05-03 (Polling Day) may incorrectly appear in the exchange holiday set and cause downstream scheduling/trading-calendar consumers to treat weekends as special closures—reapply weekend filtering (or guard static-holiday appends) after all holiday additions.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="holidays/financial/singapore_exchange.py">

<violation number="1" location="holidays/financial/singapore_exchange.py:37">
P2: Weekend special closures leak into the exchange calendar because Singapore's static holidays are appended after this loop. For example, `SingaporeExchange(years=2025)` includes Saturday 2025-05-03 (Polling Day), while this class otherwise removes non-trading weekend dates; filter special public holidays too.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

cubic-dev-ai · 2026-07-25T15:17:07Z

+    def _populate_public_holidays(self):
+        super()._populate_public_holidays()
+
+        for dt in tuple(self):


P2: Weekend special closures leak into the exchange calendar because Singapore's static holidays are appended after this loop. For example, SingaporeExchange(years=2025) includes Saturday 2025-05-03 (Polling Day), while this class otherwise removes non-trading weekend dates; filter special public holidays too.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At holidays/financial/singapore_exchange.py, line 37: <comment>Weekend special closures leak into the exchange calendar because Singapore's static holidays are appended after this loop. For example, `SingaporeExchange(years=2025)` includes Saturday 2025-05-03 (Polling Day), while this class otherwise removes non-trading weekend dates; filter special public holidays too.</comment> <file context> @@ -0,0 +1,71 @@ + def _populate_public_holidays(self): + super()._populate_public_holidays() + + for dt in tuple(self): + if self._is_weekend(dt): + self.pop(dt) </file context>

To resolve this issue, you can override _populate_common_holidays instead of _populate_public_holidays.

PPsyrius · 2026-07-25T16:04:41Z

+
+#. Chinese New Year's Eve.
+msgid "Chinese New Year's Eve"
+msgstr "วันสิ้นปีจีน"


Chinese and Vietnamese New Year in Thai l10n has their own special name:

Suggested change

msgstr "วันสิ้นปีจีน"

msgstr "วันก่อนวันตรุษจีน"

PPsyrius · 2026-07-25T16:07:28Z

l10n tests should be added here

codecov · 2026-07-25T16:12:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3754f09) to head (329a4ec).
⚠️ Report is 3 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3719   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          321       322    +1     
  Lines        19320     19346   +26     
  Branches      2477      2479    +2     
=========================================
+ Hits         19320     19346   +26

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

sonarqubecloud · 2026-07-25T18:52:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

KJhellico · 2026-07-25T18:57:26Z

+    """Singapore Exchange (SGX) holidays.
+
+    References:
+        <https://web.archive.org/web/20260725102849/https://www.sgx.com/stock-exchange/trading>


Suggested change

<https://web.archive.org/web/20260725102849/https://www.sgx.com/stock-exchange/trading>

* <https://web.archive.org/web/20260725102849/https://www.sgx.com/stock-exchange/trading>

KJhellico · 2026-07-25T19:04:21Z

+        # %s (markets close at 12:00 p.m. SGT).
+        pause_label = tr("%s (markets close at 12:00 p.m. SGT)")
+
+        self._move_holiday(


Since we're removing holidays that fall on a weekend in _populate_common_holidays, there's no need to use _move_holiday here.

pareshjoshij added 2 commits July 25, 2026 14:45

Add Singapore Exchange (SGX) holidays

7ffbe41

Add Singapore Exchange (SGX) holidays

c0743b5

Copilot AI review requested due to automatic review settings July 25, 2026 15:12

pareshjoshij requested review from KJhellico, PPsyrius and arkid15r as code owners July 25, 2026 15:12

Copilot AI reviewed Jul 25, 2026

github-actions Bot added l10n test labels Jul 25, 2026

cubic-dev-ai Bot reviewed Jul 25, 2026

View reviewed changes

PPsyrius reviewed Jul 25, 2026

View reviewed changes

pareshjoshij added 2 commits July 25, 2026 18:31

Apply suggestions

1ecbe67

update test

329a4ec

Copilot AI review requested due to automatic review settings July 25, 2026 18:51

Copilot AI reviewed Jul 25, 2026

KJhellico reviewed Jul 25, 2026

View reviewed changes

	msgstr "วันสิ้นปีจีน"
	msgstr "วันก่อนวันตรุษจีน"

	<https://web.archive.org/web/20260725102849/https://www.sgx.com/stock-exchange/trading>
	* <https://web.archive.org/web/20260725102849/https://www.sgx.com/stock-exchange/trading>

Uh oh!

Uh oh!

Conversation

pareshjoshij commented Jul 25, 2026

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jul 25, 2026

Choose a reason for hiding this comment

Uh oh!

KJhellico Jul 25, 2026

Choose a reason for hiding this comment

Uh oh!

PPsyrius Jul 25, 2026

Choose a reason for hiding this comment

Uh oh!

PPsyrius Jul 25, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 25, 2026

Quality Gate passed

Uh oh!

KJhellico Jul 25, 2026

Choose a reason for hiding this comment

Uh oh!

KJhellico Jul 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented Jul 25, 2026 •

edited

Loading

codecov Bot commented Jul 25, 2026 •

edited

Loading