Add SIX Swiss Exchange (SIX) holidays by pareshjoshij · Pull Request #3692 · vacanza/holidays

pareshjoshij · 2026-07-12T12:59:57Z

Proposed change

This PR adds the holidays for the SIX Swiss Exchange (XSWX) financial calendar and l10n support.
Part of GSoC (#3424)

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

coderabbitai · 2026-07-12T13:00:15Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Adds SIX Swiss Exchange holiday support for Zurich, including aliases, registry exposure, localized names, documentation, observed-day handling, and comprehensive tests.

Changes

SIX Swiss Exchange support

Layer / File(s)	Summary
Unified weekend suppression rule `holidays/observed_holiday_base.py`, `holidays/countries/`, `holidays/financial/`	Adds `SAT_SUN_TO_NONE` and updates existing observed-holiday rules to use it.
Holiday provider and aliases `holidays/financial/six_swiss_exchange.py`	Defines SIX Swiss Exchange metadata, Swiss public holidays, weekend suppression, and aliases.
Package registration and presentation `holidays/financial/__init__.py`, `holidays/registry.py`, `holidays/locale/*/LC_MESSAGES/XSWX.po`, `README.md`	Exports and registers the exchange codes, adds translations for six locales, and documents the market.
Holiday and localization tests `tests/financial/test_six_swiss_exchange.py`	Tests metadata, holiday dates, observed behavior, yearly output, and localized names.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

vacanza/holidays#2834: Updates the same consolidated observed-rule behavior in the National Stock Exchange of India.
vacanza/holidays#3181: Modifies the same observed-rule logic in Macau.
vacanza/holidays#3680: Modifies the Toronto Stock Exchange implementation using the consolidated rule.

Suggested reviewers: arkid15r, ppsyrius

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: adding SIX Swiss Exchange holidays.
Description check	✅ Passed	The description matches the changeset by stating that SIX Swiss Exchange holidays and localization support were added.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@holidays/locale/de/LC_MESSAGES/XSWX.po`:
- Around line 30-32: Update the translator comment for Berchtoldstag in the
Python source symbol containing “Saint Berchtold's Day” to end with a period,
then run make l10n to regenerate all locale .po files consistently.

In `@holidays/locale/en_US/LC_MESSAGES/XSWX.po`:
- Around line 30-32: Update the Saint Berchtold’s Day translator comment in
six_swiss_exchange.py to end with a period, then regenerate the locale files
with make l10n so the en_US XSWX.po comment becomes punctuated consistently.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5125c8b9-dbfb-4ec4-975a-545cceecd626

📥 Commits

Reviewing files that changed from the base of the PR and between 7429a7c and b5da028.

📒 Files selected for processing (11)

README.md
holidays/financial/__init__.py
holidays/financial/six_swiss_exchange.py
holidays/locale/de/LC_MESSAGES/XSWX.po
holidays/locale/en_US/LC_MESSAGES/XSWX.po
holidays/locale/fr/LC_MESSAGES/XSWX.po
holidays/locale/it/LC_MESSAGES/XSWX.po
holidays/locale/th/LC_MESSAGES/XSWX.po
holidays/locale/uk/LC_MESSAGES/XSWX.po
holidays/registry.py
tests/financial/test_six_swiss_exchange.py

cubic-dev-ai

No issues found across 11 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

codecov · 2026-07-12T15:45:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5095aa2) to head (e8f9a90).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3692   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          319       320    +1     
  Lines        19207     19240   +33     
  Branches      2458      2461    +3     
=========================================
+ Hits         19207     19240   +33

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@holidays/financial/six_swiss_exchange.py`:
- Line 42: Update the _add_holiday method signature by annotating its variadic
*args parameter with Any, importing Any from typing if needed, while preserving
the existing return annotation and behavior.

In `@tests/financial/test_six_swiss_exchange.py`:
- Around line 30-35: Replace the unnecessary self.full_range instance attribute
with a local full_range variable in test_berchtolds_day, test_christmas_eve, and
test_new_years_eve at tests/financial/test_six_swiss_exchange.py ranges 30-35,
39-44, and 48-53 respectively, and update each generator to use the local
variable.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ce66b938-2fe3-4632-b67c-d56e4f1705d5

📥 Commits

Reviewing files that changed from the base of the PR and between 01884cc and b8c6257.

📒 Files selected for processing (2)

holidays/financial/six_swiss_exchange.py
tests/financial/test_six_swiss_exchange.py

sonarqubecloud · 2026-07-15T10:48:05Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

PPsyrius

LGTM 🇨🇭

KJhellico

LGTM.

git commit -m fix_formating

b5da028

Copilot AI review requested due to automatic review settings July 12, 2026 12:59

pareshjoshij requested review from KJhellico, PPsyrius and arkid15r as code owners July 12, 2026 12:59

Copilot AI reviewed Jul 12, 2026

github-actions Bot added l10n test labels Jul 12, 2026

coderabbitai Bot reviewed Jul 12, 2026

View reviewed changes

Comment thread holidays/locale/de/LC_MESSAGES/XSWX.po Outdated

Comment thread holidays/locale/en_US/LC_MESSAGES/XSWX.po Outdated

cubic-dev-ai Bot reviewed Jul 12, 2026

View reviewed changes

add trailing period

729e205

KJhellico reviewed Jul 13, 2026

View reviewed changes

KJhellico changed the title ~~Add SIX Swiss Exchange (XSWX) holidays~~ Add SIX Swiss Exchange (SIX) holidays Jul 13, 2026

KJhellico reviewed Jul 13, 2026

View reviewed changes

Comment thread tests/financial/test_six_swiss_exchange.py Outdated

pareshjoshij added 2 commits July 13, 2026 15:16

Apply suggestions

a7ad3bb

added SAT_SUN_TO_NONE to constants set

01884cc

pareshjoshij mentioned this pull request Jul 14, 2026

Add London Stock Exchange (LSE) holidays #3654

Open

Apply suggestions

b8c6257

coderabbitai Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread holidays/financial/six_swiss_exchange.py

Comment thread tests/financial/test_six_swiss_exchange.py Outdated

PPsyrius reviewed Jul 15, 2026

View reviewed changes

Comment thread holidays/locale/th/LC_MESSAGES/XSWX.po Outdated

Comment thread tests/financial/test_six_swiss_exchange.py Outdated

Comment thread tests/financial/test_six_swiss_exchange.py

Refactor tests

e8f9a90

PPsyrius approved these changes Jul 15, 2026

View reviewed changes

arkid15r requested a review from KJhellico July 16, 2026 18:03

KJhellico approved these changes Jul 16, 2026

View reviewed changes

arkid15r added this pull request to the merge queue Jul 20, 2026

Merged via the queue into vacanza:dev with commit df6abc9 Jul 20, 2026
33 checks passed

Uh oh!

Uh oh!

Conversation

pareshjoshij commented Jul 12, 2026

Proposed change

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jul 15, 2026

Quality Gate passed

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai Bot commented Jul 12, 2026 •

edited

Loading

codecov Bot commented Jul 12, 2026 •

edited

Loading