-
-
Notifications
You must be signed in to change notification settings - Fork 705
Update India holidays: subdiv holidays improvement (North region) #3666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ankushhKapoor
wants to merge
24
commits into
vacanza:dev
Choose a base branch
from
ankushhKapoor:fix-IN-1.1
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8c536b6
add punjab holidays
ankushhKapoor a42fa58
add Himachal Pradesh holidays
ankushhKapoor 67ff5ef
add hp women's optional holidays
ankushhKapoor 365d287
extend Maharana Pratap Jayanti dates and arrange subdiv holidays test…
ankushhKapoor c6e9311
add punjab tests
ankushhKapoor 569ac2d
added himachal pradesh tests
ankushhKapoor e6b0867
add women optional category
ankushhKapoor 870d2c6
add ladakh holidays
ankushhKapoor 8f6f642
add jammu kashmir holidays
ankushhKapoor f8398e6
fix nauroz implementation
ankushhKapoor b6f3fdc
Merge branch 'dev' into fix-IN-1.1
ankushhKapoor e3026fe
some fixes
ankushhKapoor 3e85750
add Haryana holidays
ankushhKapoor 3924c44
add Haryana tests
ankushhKapoor 7f4fde3
standardise holiday names
ankushhKapoor 83d9418
add Uttarakhand holidays
ankushhKapoor 0f641d8
improved .po files
ankushhKapoor 00c5c88
add Chandigarh holidays
ankushhKapoor 818099b
name fixes
ankushhKapoor 60c9573
add more holidays
ankushhKapoor b929362
minor name fixes
ankushhKapoor 44dac6b
add more holidays
ankushhKapoor e430506
minor fixes
ankushhKapoor 9a63bfe
Merge branch 'dev' into fix-IN-1.1
ankushhKapoor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
Accessor out of alphabetical order.
kabir_jayanti_dateis placed afterkarwa_chauth_date, but theKABIR_JAYANTI_DATESdict itself is correctly ordered beforeKARWA_CHAUTH_DATESalphabetically. Every other accessor method in this class mirrors its DATES-dict ordering — this one breaks that pattern.♻️ Suggested fix
🤖 Prompt for AI Agents