Add checks to RawGhostFile

.gitignore

@@ -1,9 +1,12 @@
 build
 build.ninja
+compile_commands.json
+.cache/**
 __pycache__
 out
 .vs
 .vscode
+.zed
 *.szs
 statusTestCases.json
 .env

source/game/system/GhostFile.cc

@@ -142,19 +142,29 @@ bool RawGhostFile::decompress(const u8 *rkg) {
 
 /// @addr{0x8051C120}
 /// @todo Check for valid controller type?
-/// @todo Check lap times sum to race time?
 bool RawGhostFile::isValid(const u8 *rkg) const {
     if (strncmp(reinterpret_cast<const char *>(rkg), "RKGD", 4) != 0) {
         PANIC("RKG header malformed");
         return false;
     }
+
+    u32 finalTime = RawGhostFile::readRKGTime(reinterpret_cast<const u8 *>(rkg + 0x4));
+    u32 lapSum = 0;
+    for (u8 i = 0; i < 8; i++) {
+        lapSum += RawGhostFile::readRKGTime(reinterpret_cast<const u8 *>(rkg + 0x11 + (i*3)));
+    }
 
+    if (finalTime != lapSum) {
+        return false;
+    }
+
     u32 ids = parse<u32>(*reinterpret_cast<const u32 *>(rkg + 0x8));
     Vehicle vehicle = static_cast<Vehicle>(ids >> 0x1a);
     Character character = static_cast<Character>((ids >> 0x14) & 0x3f);
     u8 year = (ids >> 0xd) & 0x7f;
-    u8 day = (ids >> 0x4) & 0x1f;
     u8 month = (ids >> 0x9) & 0xf;
+    u8 day = (ids >> 0x4) & 0x1f;
+    u8 controllerType = ids & 0b1111;
 
     if (vehicle >= Vehicle::Max || character >= Character::Max) {
         return false;
@@ -163,6 +173,10 @@ bool RawGhostFile::isValid(const u8 *rkg) const {
     if (year >= 100 || day >= 32 || month > 12) {
         return false;
     }
+
+    if (controllerType > 3) {
+        return false;
+    }
 
     // Validate weight class match
     WeightClass charWeight = CharacterToWeight(character);
@@ -181,6 +195,13 @@ bool RawGhostFile::isValid(const u8 *rkg) const {
     return true;
 }
 
+u32 RawGhostFile::readRKGTime(const u8 *timeBytes) const {
+    u32 minutes = *timeBytes; // The minutes are doubled here
+    u32 seconds = (*reinterpret_cast<const u8 *>(timeBytes + 1)) >> 2;
+    u32 milliseconds = parse<u16>(*reinterpret_cast<const u16 *>(timeBytes + 1)) & 0b1111111111;
+    return (minutes * 30000) + (seconds * 1000) + milliseconds;
+}
+
 const u8 *RawGhostFile::buffer() const {
     return m_buffer;
 }

source/game/system/GhostFile.hh

@@ -70,6 +70,7 @@ public:
 
 private:
     [[nodiscard]] bool compressed(const u8 *rkg) const;
+    [[nodiscard]] u32 readRKGTime(const u8 *rkg) const;
 
     u8 m_buffer[RKG_UNCOMPRESSED_FILE_SIZE];
 };