Skip to content

fix: install pnpm deps in hoisted mode + declare @babel/types (#24288) (CP: 24.10) #24297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZheSun88 merged 1 commit into from
May 8, 2026

fix: install pnpm deps in hoisted mode + declare @babel/types (#24288…

489c332
Select commit
Loading
Failed to load commit list.
Merged

fix: install pnpm deps in hoisted mode + declare @babel/types (#24288) (CP: 24.10) #24297

fix: install pnpm deps in hoisted mode + declare @babel/types (#24288…
489c332
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 8, 2026 in 57s

Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 320 in flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeUpdatePackagesNpmVersionLockingTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the parentheses around the "nonObjectNode" parameter 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ4GahblxVtjJLMjTl3V&open=AZ4GahblxVtjJLMjTl3V&pullRequest=24297

Check warning on line 860 in flow-server/src/test/java/com/vaadin/flow/router/internal/NavigationStateRendererTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated method, it has been marked for removal. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ4Gahe4xVtjJLMjTl3b&open=AZ4Gahe4xVtjJLMjTl3b&pullRequest=24297

Check warning on line 200 in flow-plugins/flow-plugin-base/src/test/java/com/vaadin/flow/server/scanner/ReflectionsClassFinderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertNotEquals instead. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ4Gahg-xVtjJLMjTl3e&open=AZ4Gahg-xVtjJLMjTl3e&pullRequest=24297

Check warning on line 1118 in flow-server/src/test/java/com/vaadin/flow/server/frontend/AbstractNodeUpdatePackagesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the parentheses around the "plainValue" parameter 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ4GahW_xVtjJLMjTl3U&open=AZ4GahW_xVtjJLMjTl3U&pullRequest=24297

Check warning on line 417 in flow-server/src/test/java/com/vaadin/flow/server/frontend/TaskUpdatePackagesNpmTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "packageJson" which hides the field declared at line 96. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ4GahcUxVtjJLMjTl3Y&open=AZ4GahcUxVtjJLMjTl3Y&pullRequest=24297

Check warning on line 822 in flow-server/src/test/java/com/vaadin/flow/router/internal/NavigationStateRendererTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated method, it has been marked for removal. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ4Gahe4xVtjJLMjTl3a&open=AZ4Gahe4xVtjJLMjTl3a&pullRequest=24297

Check failure on line 298 in flow-plugins/flow-maven-plugin/src/test/java/com/vaadin/flow/plugin/maven/ReflectorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ4GahgVxVtjJLMjTl3d&open=AZ4GahgVxVtjJLMjTl3d&pullRequest=24297

Check warning on line 55 in flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeUpdatePackagesNpmVersionLockingTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "RELATIVE_DEPENDENCY_VERSION" private field. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ4GahblxVtjJLMjTl3W&open=AZ4GahblxVtjJLMjTl3W&pullRequest=24297

Check warning on line 248 in flow-server/src/test/java/com/vaadin/flow/server/frontend/TaskUpdatePackagesNpmTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the parentheses around the "nonObjectNode" parameter 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ4GahcUxVtjJLMjTl3X&open=AZ4GahcUxVtjJLMjTl3X&pullRequest=24297

Check warning on line 224 in vaadin-dev-server/src/test/java/com/vaadin/base/devserver/AbstractDevServerRunnerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ4GahfwxVtjJLMjTl3c&open=AZ4GahfwxVtjJLMjTl3c&pullRequest=24297

Check warning on line 1482 in flow-server/src/test/java/com/vaadin/flow/server/frontend/TaskUpdatePackagesNpmTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertNotEquals instead. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ4GahcUxVtjJLMjTl3Z&open=AZ4GahcUxVtjJLMjTl3Z&pullRequest=24297
View more details on SonarQubeCloud